Skip to content

Conversation

@harsh-akamai
Copy link
Contributor

Description 📝

Many components were previously setting the error color for at different levels (inline styles, wrappers, or custom themes). This PR centralizes and simplifies the error handling by consistently passing the error prop, allowing MUI to apply the appropriate styling internally.

Changes 🔄

  • Replace component specific logic for setting error color
  • Fix the error color for components that have a different shade of red

Target release date 🗓️

Preview 📷

Before After
screenshot-1 image
image image

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

  • Switch to develop branch
  • Use the light theme
  • Try creating a K8 cluster without a label and observe the error color to be darker than other error fields
  • Navigate to the Nodebalancer Summary page
  • Try creating a Nodebalancer Configuration without any backend nodes and observe the error text to be lighter in color

Verification steps

  • Ensure that all above fields use the same error color as defined by the design system.
  • Verify that the error colors for all components are correctly applied when using the error prop.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@harsh-akamai harsh-akamai marked this pull request as ready for review July 25, 2025 13:00
@harsh-akamai harsh-akamai requested a review from a team as a code owner July 25, 2025 13:00
@harsh-akamai harsh-akamai requested review from coliu-akamai, dwiley-akamai, hana-akamai and hasyed-akamai and removed request for a team July 25, 2025 13:00
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed LKE cluster create and nodebalancer nodes erroring looks good
✅ checked changed files and erroring looks good
✅ spotchecked CM + storybook - looks good

thanks @harsh-akamai! I think we'll need a changeset since this is going to develop? (not sure if we'd want to remove the changelog entry from the other pr in 1.147.0 though)

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 25, 2025
@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Jul 25, 2025
@mjac0bs
Copy link
Contributor

mjac0bs commented Jul 25, 2025

I think we'll need a changeset since this is going to develop?

Yep.

(not sure if we'd want to remove the changelog entry from the other pr in 1.147.0 though)

Wish I'd thought of that in the other changelog update I made to staging. Addressed now, though, in d663a46. Thanks Connie!

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 690 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing690 Passing4 Skipped124m 49s

@harsh-akamai harsh-akamai merged commit 6077b3d into linode:develop Jul 28, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants