-
Notifications
You must be signed in to change notification settings - Fork 390
fix: [M3-10264] - Disabled Autocomplete Options #12583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-10264] - Disabled Autocomplete Options #12583
Conversation
mjac0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloud Manager UI test results🎉 690 passing tests on test run #5 ↗︎
|
|
@mjac0bs I think I got the scroll / tooltip overflow behavior somewhat better. It should now be similar to how production works. Not perfect, but as good as I can get it... |
|
@mjac0bs Nevermind, that broke tooltip interactivity. I don't really have a sound solution for preventing tooltip overflow... I think I'll need some help here, or we can merge this because I think this PR makes a net improvement, and we can look to iterate on the tooltip's behavior |
|
Sorry that tooltip's been a handful! I'll take a look again with the latest, but given that it's somewhat of an existing issue made slightly more prevalent, I'm okay with the changes you made and doing further follow up on tooltip behavior too. |
mjac0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got deep in the weeds of the Popover's modifier prop before creating a ticket M3-10400.
Popper.js is based on a "plugin-like" architecture, most of its features are fully encapsulated "modifiers". A modifier is a function that is called each time Popper.js needs to compute the position of the popper. For this reason, modifiers should be very performant to avoid bottlenecks. To learn how to create a modifier, read the modifiers documentation.
pmakode-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ux question (non-blocking): Not sure if this is a UX issue or something for a follow-up ticket, but I noticed that when the cursor is already over the dropdown and you start using the keyboard, the focus/highlight jumps around based on the cursor position, which feels a bit confusing. It works fine when the cursor is outside the list
Screen.Recording.2025-07-31.at.6.47.47.PM.mov
That may be something we're doing with CSS, the MUI Autocomplete does not do this. I'll create a ticket - thanks @pmakode-akamai |
|
Going to merge so that disabled states work again. Hopefully we can dial in focus and tooltip behavior in the future. (M3-10400) |
This reverts commit 0eea9b0.
I removed autoHighlight #12583 and I believe it broke a ton of cypress tests (thanks for catching @jdamore-linode ) Co-authored-by: Banks Nussman <banks@nussman.us>

Description 📝
This PR makes some fixes related to disabled options in Autocompletes:
aria-disabledis set tofalseon disabled Autocomplete optionsaria-disabledshould now be set totruefor disabled optionsPreview 📷
Region Select
Placement Group Select
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅