-
Notifications
You must be signed in to change notification settings - Fork 390
fix: [M3-9986] - Selected Geographical Area state in Distributed Region select #12584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hana-akamai
merged 4 commits into
linode:develop
from
hana-akamai:M3-9986-distributed-region-geo-area-select-bug
Jul 28, 2025
Merged
fix: [M3-9986] - Selected Geographical Area state in Distributed Region select #12584
hana-akamai
merged 4 commits into
linode:develop
from
hana-akamai:M3-9986-distributed-region-geo-area-select-bug
Jul 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
approved these changes
Jul 28, 2025
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left some comments with test improvements/clean up
packages/manager/src/features/Linodes/LinodeCreate/TwoStepRegion.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodeCreate/TwoStepRegion.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodeCreate/TwoStepRegion.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodeCreate/TwoStepRegion.test.tsx
Show resolved
Hide resolved
dwiley-akamai
approved these changes
Jul 28, 2025
Contributor
dwiley-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix confirmed & no regressions observed ✅
Code review ✅
Checks pass ✅
Collaborator
Cloud Manager UI test results🎉 690 passing tests on test run #3 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix selected Geographical Area persistence issue when switching between Core and Distributed Region tabs
Preview 📷
before.mov
after.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅