Skip to content

Conversation

@rodonnel-akamai
Copy link
Contributor

Description 📝

When you remove the last entity on a page in the entity access for a user, the table was not rendering anything because the pagination was staying where it was. This update resets the page to page 1 if the user has removed the last entity assignment on a page.

Target release date 🗓️

August 3

Preview 📷

Before After
image-2025-06-26-15-52-21-320 Screenshot 2025-07-26 at 4 32 38 PM
Screenshot 2025-07-26 at 4 33 08 PM

How to test 🧪

Prerequisites

(How to setup test environment)

  • devcloud IAM account or local devenv setup or mock data (use the User Permissions presets)
  • Note: The unrestricted account has full access — permission checks are skipped.

Reproduction steps

(How to reproduce the issue, if applicable)

  • Go to "Identity & Access" with a user with account permissions that allow them to assign roles to other users
  • Assign enough entity roles to get a second page of entities when looking at the "Entity Access" tab for the user being changed
  • Go to the second page
  • Remove the entity assignments so until there are none on the page - before this fix, the page would render as in the screenshot without any table rows

Verification steps

(How to verify changes)

  • Go to "Identity & Access" with a user with account permissions that allow them to assign roles to other users
  • Assign enough entity roles to get a second page of entities when looking at the "Entity Access" tab for the user being changed
  • Go to the second page
  • Remove the entity assignments so until there are none on the page - once you remove the last one, it should go back to the first page. This should work for any number of pages (i.e. deleting the last one on the 7th page for instance)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@rodonnel-akamai rodonnel-akamai requested a review from a team as a code owner July 26, 2025 20:43
@rodonnel-akamai rodonnel-akamai requested review from cpathipa and hasyed-akamai and removed request for a team July 26, 2025 20:43
@corya-akamai corya-akamai self-requested a review July 30, 2025 14:21
Copy link
Contributor

@corya-akamai corya-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed deleting last entity redirects to page 1

@corya-akamai corya-akamai added the Add'tl Approval Needed Waiting on another approval! label Jul 30, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 4 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
4 Failing697 Passing4 Skipped136m 46s

Details

Failing Tests
SpecTest
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » linode storage tab

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 30, 2025
@hasyed-akamai hasyed-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 31, 2025
Copy link

@kwojtowiakamai kwojtowiakamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ The table goes to the 1. page after removing the last row in the page.

@corya-akamai
Copy link
Contributor

Cloud Manager UI test results

🔺 4 failing tests on test run #3 ↗︎

❌ Failing ✅ Passing ↪️ Skipped 🕐 Duration
4 Failing 697 Passing 4 Skipped 136m 46s

Details

Failing Tests
Spec Test
lke-create.spec.ts Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.ts Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.ts Cloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
linode-storage.spec.ts Cloud Manager Cypress Tests→linode storage tab » linode storage tab

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

#12561 (comment)

@corya-akamai corya-akamai merged commit 2253937 into linode:develop Jul 31, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 31, 2025
@corya-akamai corya-akamai deleted the UIE-8955-entity-table-fix-remove-causes-empty-page branch July 31, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants