-
Notifications
You must be signed in to change notification settings - Fork 390
fix: [M3-10351] - Align Encrypt Volume checkbox in Volume Create with other fields #12592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@bnussman-akamai and @coliu-akamai Thank you for the feedback, addressed the feedback and ready for re-review - 33ff139 |
coliu-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ confirmed alignment with linode create, rebuild, and both volume create forms
thanks @cpathipa!
Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
Cloud Manager UI test results🔺 5 failing tests on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts" |
|||||||||||||||||||||||||||||

Description 📝
This PR fixes the alignment of Encrypt Volume checkbox in volume create page and add volume drawer.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
8/12
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅