Skip to content

Conversation

@cpathipa
Copy link
Contributor

Description 📝

This PR fixes the alignment of Encrypt Volume checkbox in volume create page and add volume drawer.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Encryption.tsx
  • LinodeVolumeCreateForm.tsx
  • VolumeCreate.tsx
  • Checkbox.tsx

Target release date 🗓️

8/12

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
image image

How to test 🧪

Verification steps

(How to verify changes)

  • Navigate to http://localhost:3000/volumes/create
  • Verify the alignment of Encrypt Volume checkbox
  • Navigate add volume page from linode details storage tab
  • Verify the alignment of Encrypt Volume checkbox.
  • Verify there no regressions.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@cpathipa cpathipa requested a review from a team as a code owner July 28, 2025 21:29
@cpathipa cpathipa requested review from harsh-akamai and hasyed-akamai and removed request for a team July 28, 2025 21:29
@cpathipa cpathipa self-assigned this Jul 28, 2025
@cpathipa cpathipa added the Bug Fixes for regressions or bugs label Jul 28, 2025
@hasyed-akamai hasyed-akamai added the Add'tl Approval Needed Waiting on another approval! label Jul 29, 2025
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Volume Encryption on Volume Create and Linode Add volume flow looks good
❓ Seeing that the checkbox in Linode Create/Rebuild Disk Encryption is a little shifted now though (they use the Encryption component):

image

@github-project-automation github-project-automation bot moved this from Review to Changes Requested in Cloud Manager Jul 29, 2025
@cpathipa
Copy link
Contributor Author

@bnussman-akamai and @coliu-akamai Thank you for the feedback, addressed the feedback and ready for re-review - 33ff139

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ confirmed alignment with linode create, rebuild, and both volume create forms

thanks @cpathipa!

Co-authored-by: Connie Liu <139280159+coliu-akamai@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in Cloud Manager Jul 29, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 5 failing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
5 Failing696 Passing4 Skipped134m 22s

Details

Failing Tests
SpecTest
object-storage-objects-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster objects » Object Storage Multicluster objects
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » linode storage tab
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts"

@harsh-akamai harsh-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 30, 2025
@cpathipa cpathipa merged commit 62b4fe0 into linode:develop Jul 30, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants