Skip to content

fix: [M3-10336] - Checkbox color token - pt2 #12603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hasyed-akamai merged 4 commits into from
Aug 1, 2025
Merged

fix: [M3-10336] - Checkbox color token - pt2 #12603

hasyed-akamai merged 4 commits into from
Aug 1, 2025

Conversation

@hasyed-akamai
Copy link
Contributor

@hasyed-akamai hasyed-akamai commented Jul 30, 2025 •
edited
Loading

Description

This PR fixes checkbox styling issues:

  • Changing the check icon color from black to white.
  • Applying correct color tokens for all checkbox states.

Changes

  • Updated check icon color for dark mode.
  • Applied proper color tokens to all checkbox variants.

Target Release

N/A

Preview

Before After
Before After

How to Test

  1. Enable dark mode.
  2. Locate checkboxes across the UI.
  3. Confirm white check icon in the disabled state.

Acceptance

  • Correct Check icon color in dark mode.
  • All variants use proper color tokens.
Author Checklists

As an Author, I considered:

  • Self-review
  • Contribution guidelines
  • Small, focused PR
  • Changeset added if needed
  • Tests added or updated
  • No sensitive info
  • Feature flag if needed
  • Reproduction steps
  • Docs updated if needed
  • Mobile and a11y support

Before moving from Draft to Open:

  • All unit tests passing
  • TypeScript compiles
  • Linting passes

@hasyed-akamai hasyed-akamai self-assigned this Jul 30, 2025
@hasyed-akamai hasyed-akamai added the Design Tokens Laying the groundwork for Design Tokens label Jul 31, 2025
@hasyed-akamai hasyed-akamai marked this pull request as ready for review July 31, 2025 10:15
@hasyed-akamai hasyed-akamai requested a review from a team as a code owner July 31, 2025 10:15
@hasyed-akamai hasyed-akamai requested review from bnussman-akamai, davyd-akamai, dwiley-akamai and tzmiivsk-akamai and removed request for a team July 31, 2025 10:15
@linode-gh-bot
Copy link
Collaborator

linode-gh-bot commented Jul 31, 2025

Cloud Manager UI test results

🎉 701 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing701 Passing4 Skipped119m 12s

davyd-akamai
davyd-akamai approved these changes Jul 31, 2025
View reviewed changes
Copy link

@davyd-akamai davyd-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 31, 2025
@hasyed-akamai hasyed-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Aug 1, 2025
@hasyed-akamai hasyed-akamai merged commit 97733f5 into linode:develop Aug 1, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 1, 2025
@jaalah-akamai jaalah-akamai mentioned this pull request Aug 6, 2025
Merged
@bnussman-akamai bnussman-akamai mentioned this pull request Aug 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

+2 more reviewers

@davyd-akamai davyd-akamai davyd-akamai approved these changes

@tzmiivsk-akamai tzmiivsk-akamai tzmiivsk-akamai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hasyed-akamai hasyed-akamai

Labels

Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens

Projects

Cloud Manager
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hasyed-akamai @linode-gh-bot @dwiley-akamai @bnussman-akamai @davyd-akamai @tzmiivsk-akamai