Skip to content

Conversation

@jaalah-akamai
Copy link
Contributor

Description 📝

This PR modifies the Flag component to conditionally apply CSS borders only to specific countries that require visual distinction. At one time, all flags had borders applied by default, but now borders are only shown for countries that need them for better visual clarity.

Changes 🔄

  • Added a list of 3 countries corresponding to our DCs that need borders, using country codes as outlined by UX

Target release date 🗓️

N/A

Preview 📷

Before After
Screenshot 2025-07-30 at 9 53 47 AM Screenshot 2025-07-30 at 9 31 13 AM

How to test 🧪

Verification steps

  • Go to create linodes
  • Open region selector
  • Observe these 3 flags have borders
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai jaalah-akamai self-assigned this Jul 30, 2025
@jaalah-akamai jaalah-akamai requested a review from a team as a code owner July 30, 2025 13:54
@jaalah-akamai jaalah-akamai added the Bug Fixes for regressions or bugs label Jul 30, 2025
@jaalah-akamai jaalah-akamai requested review from bnussman-akamai and hasyed-akamai and removed request for a team July 30, 2025 13:54
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 5 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
5 Failing374 Passing12 Skipped75m 23s

Details

Failing Tests
SpecTest
third-party-access-tokens.spec.tsCloud Manager Cypress Tests→Third party access tokens » Third party access tokens
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
lke-create.spec.tsCloud Manager Cypress Tests→LKE Cluster Creation with ACL→with LKE IPACL account capability » LKE Cluster Creation with ACL→with LKE IPACL account capability
service-transfer.spec.tsCloud Manager Cypress Tests→Account service transfers » Account service transfers

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/third-party-access-tokens.spec.ts,cypress/e2e/core/kubernetes/lke-create.spec.ts,cypress/e2e/core/account/service-transfer.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 31, 2025
@hasyed-akamai hasyed-akamai added the Approved Multiple approvals and ready to merge! label Jul 31, 2025
@jaalah-akamai jaalah-akamai merged commit 7662ca0 into linode:develop Jul 31, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants