Skip to content

Conversation

@mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Jul 30, 2025

Description 📝

Makes small tweaks to our PR template based on team retro discussion on 7/30.

Changes 🔄

  • Moves the bottom section of the PR to a HTML comment, hiding it from view but preserving the content
    • This means we don't have to manually delete it from all our PRs
  • Adds a checkbox underneath the Changes section as an attempt at quick visual confirmation whether changes are customer-facing
    • Adding this because we have so many projects with feature flags in various states; I'm open to feedback on it!

Target release date 🗓️

N/A

Preview 📷

Screenshot 2025-07-30 at 1 44 47 PM

Verification steps

(How to verify changes)

  • Read the diff
  • Provide your input
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs requested a review from a team as a code owner July 30, 2025 20:15
@mjac0bs mjac0bs requested review from coliu-akamai and harsh-akamai and removed request for a team July 30, 2025 20:15
@mjac0bs mjac0bs changed the title Pr template updates 07 30 25 change: Improve PR template based on team feedback Jul 30, 2025
@mjac0bs mjac0bs self-assigned this Jul 30, 2025
@mjac0bs
Copy link
Contributor Author

mjac0bs commented Jul 30, 2025

@bill-akamai Do you want to add your changes re: request for videos for multi-step processes to this PR?

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mjac0bs!

Copy link
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjac0bs That's ok - I had just made a separate PR here: #12608

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jul 30, 2025
@mjac0bs mjac0bs added the Documentation Improving / adding to our documentation label Jul 30, 2025
@mjac0bs mjac0bs force-pushed the pr-template-updates-07-30-25 branch from a1fe5ba to 836f8ff Compare July 30, 2025 20:43
@mjac0bs mjac0bs merged commit 9675774 into linode:develop Jul 30, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improving / adding to our documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants