Skip to content

Conversation

@hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Jul 30, 2025

Description 📝

Refactor types so that LinodeCreateFormValues satisfies the CreateLinodeSchema type without any omitting of types

Changes 🔄

There should be no visual changes

Verification steps

(How to verify changes)

  • Ensure Linode creation with VPC IPv4 still works as expected
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hana-akamai hana-akamai self-assigned this Jul 30, 2025
@hana-akamai hana-akamai added Linodes Dealing with the Linodes section of the app VPC Relating to VPC project Tech Debt labels Jul 30, 2025
@hana-akamai hana-akamai marked this pull request as ready for review August 1, 2025 18:41
@hana-akamai hana-akamai requested a review from a team as a code owner August 1, 2025 18:41
@hana-akamai hana-akamai requested review from bill-akamai, bnussman-akamai and mjac0bs and removed request for a team August 1, 2025 18:41
@hana-akamai hana-akamai force-pushed the M3-10038-linode-create-legacy-type-safety branch from e09f1d1 to f1fbf21 Compare August 6, 2025 17:30
@hana-akamai hana-akamai force-pushed the M3-10038-linode-create-legacy-type-safety branch from 89cbdf8 to 2ff85df Compare August 8, 2025 18:38
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing703 Passing4 Skipped127m 33s

Details

Failing Tests
SpecTest
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk
restricted-user-details-pages.spec.tsCloud Manager Cypress Tests→restricted user details pages » should disable action elements and buttons in the 'Linodes' details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/account/restricted-user-details-pages.spec.ts"

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any regressions! Thanks for handling this!

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 11, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 11, 2025
@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 11, 2025
@hana-akamai hana-akamai merged commit cfc2aa9 into linode:develop Aug 11, 2025
34 of 35 checks passed
@hana-akamai hana-akamai deleted the M3-10038-linode-create-legacy-type-safety branch August 11, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Linodes Dealing with the Linodes section of the app Tech Debt VPC Relating to VPC project

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants