Skip to content

Conversation

@santoshp210-akamai
Copy link
Contributor

@santoshp210-akamai santoshp210-akamai commented Aug 1, 2025

Description 📝

Consuming the updated aclpAlerting LD flag for the Account alert and metric limits

Changes 🔄

List any change(s) relevant to the reviewer.

  • Updated the aclpAlerting featureFlag.
  • Updated the logic in AlertListing to consume the aclpAlerting flag
  • Updated relevant UTs for PrimaryNav component by including the new aclpAlerting props.
  • Added cypress tests.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

12th August

Preview 📷

No Visible UI changes

Case UI
Alerts Limit image
Metrics Limit image
Alerts and Metrics Limit image

How to test 🧪

Prerequisites

(How to setup test environment)

  • Navigate to Monitor, then Alerts.
  • Currently this LD Change is present in Alpha and DevCloud env

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • Verify that the limits are not hardocoded and are controlled via aclpAlerting LD flag.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@santoshp210-akamai santoshp210-akamai requested review from a team as code owners August 1, 2025 13:45
@santoshp210-akamai santoshp210-akamai requested review from dmcintyr-akamai, harsh-akamai and pmakode-akamai and removed request for a team August 1, 2025 13:45
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing703 Passing4 Skipped123m 54s

Details

Failing Tests
SpecTest
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk
qemu-reboot-upgrade-notice.spec.tsCloud Manager Cypress Tests→QEMU reboot upgrade notification » should display maintenance banner in 'Linode' landing page when one or more Linodes get impacted.

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/notificationsAndEvents/qemu-reboot-upgrade-notice.spec.ts"

@santoshp210-akamai santoshp210-akamai added the Approved Multiple approvals and ready to merge! label Aug 4, 2025
@nikhagra-akamai nikhagra-akamai merged commit 41d507a into linode:develop Aug 5, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants