-
Notifications
You must be signed in to change notification settings - Fork 390
fix: [M3-10286] - Premature validation of Linode Alert numeric input #12626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-10286] - Premature validation of Linode Alert numeric input #12626
Conversation
dmcintyr-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create a subtask for tests?
mjac0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing!
I'm pretty sure I'd observed this behavior before and noted as an existing issue, which is probably why you tagged me on this PR. 👍🏼
✅ Observed the bug, observed these changes address it, confirmed no console errors.
@pmakode-akamai re: the non-human-readable error messages for several of the fields - is this something we can submit to the API team for intake as a bug ticket?
Going to merge this PR so the issue remains reproducible and easy to reference. EDIT: After taking another look, it looks like the validation issue is actually at the Linode Alerts object validation schema level in CM, not in the API 🤦🏻♂️. I'll open a quick follow-up PR to address it there. Edit-2: Resolved validation message issue in PR: #12635 |
@dmcintyr-akamai Created M3-10433 ✅ |
Cloud Manager UI test results🔺 3 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/notificationsAndEvents/qemu-reboot-upgrade-notice.spec.ts,cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts" |
|||||||||||||||||||||||
Description 📝
Premature validation of the numeric inputs in the Linode alerts tab prevents the user from updating the value. The bug is at a Linode details page such as https://cloud.linode.com/linodes/:id/alerts
This field requires a non-null value, but in a text input the natural behavior is to either 1) select the entire current value and then hit delete/backspace, or 2) place the cursor at the end of the text string and then repeatedly hit backspace. Because this is a required field, a null value in the numeric input disables the toggle switch which then disables the numeric input that the user is attempting to edit.
If I want to change the text value from "180" to "90", i am required to update individual characters and never leave the input blank. The attached screenshot recording demonstrates the bug and the odd workaround that is necessary to replace the current value.
Note
Addressing this in a follow-up PR
Screenshot
Changes 🔄
0Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
N/A
Preview 📷
Screen.Recording.2025-08-04.at.1.03.18.PM.mov
Screen.Recording.2025-08-04.at.12.58.43.PM.mov
How to test 🧪
Reproduction steps
Verification steps
0sets the toggle to the OFF state and keeps the input field disabledAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅