-
Notifications
You must be signed in to change notification settings - Fork 391
feat: [UIE-8872] - IAM RBAC - Firewalls / Nodebalancers permissions #12641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [UIE-8872] - IAM RBAC - Firewalls / Nodebalancers permissions #12641
Conversation
… Add Node Balancer drawer
|
Permission listing: https://collaborate.akamai.com/confluence/spaces/PORTALENG/pages/1147087703/Phase+I+FGA+model
|
Cloud Manager UI test results🔺 3 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/account/restricted-user-details-pages.spec.ts,cypress/e2e/core/notificationsAndEvents/qemu-reboot-upgrade-notice.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts" |
|||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking): When role is firewall_viewer and nodebalancer_admin and you manually go to the route /firewalls/<id>/nodebalancers/add which opens the drawer, we may want to disable the Add button and add a restricted notice like we do in other drawers.
The adding of the firewall gets blocked by the API, but we probably want to prevent a user from thinking they can do this to begin with.
![]() |
![]() |
|
Nice catch @jaalah-akamai, @rodonnel-akamai can you add a follow up ticket? |
|
…inode#12641) * feat: [UIE-8872] - IAM RBAC - Firewalls / Nodebalancers permissions * Added changeset: Added IAM permission check to the Firewall Details / Add Node Balancer drawer








Description 📝
This PR adds the new IAM permissions feature to the Firewall details / Node Balancers UI. The only needed update was to the Add drawer.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
Aug 13
Preview 📷
How to test 🧪
Prerequisites
create_firewall_devicevaluesReproduction steps
(How to reproduce the issue, if applicable)
create_firewall_devicecapability can add Node Balancers via this drawercreate_firewall_devicecapability cannot add Node Balancers via this drawerVerification steps
(How to verify changes)
create_firewall_device, verify you can add Node Balancers to a firewallcreate_firewall_device, verify you can NOT add Node BalancersAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅