Skip to content

Conversation

@bill-akamai
Copy link
Contributor

@bill-akamai bill-akamai commented Aug 6, 2025

Description 📝

This PR addresses security vulnerabilities identified by SAST scanning by pinning third-party GitHub Actions to specific commit SHAs instead of mutable references like @master or @v4.

Changes 🔄

  • Pin pnpm/action-setup@v4 to commit SHA a7487c7e89a18df4991f7f222e4898a00d66ddda (v4.1.0)
  • Pin rtCamp/action-slack-notify@master to commit SHA e31e87e03dd19038e411e38ae27cbad084a90661 (v2.3.3)
  • Pin jakejarvis/s3-sync-action@master to commit SHA be0c4ab89158cac4278689ebedd8407dd5f35a83 (v0.5.1)
  • Pin cypress-io/github-action@v6 to commit SHA b8ba51a856ba5f4c15cf39007636d4ab04f23e3c (v6.10.2)
  • Pin oven-sh/setup-bun@v2 to commit SHA 735343b667d3e6f658f44d0eca948eb6282f2b76 (v2.0.2)
  • Pin pnpm/action-setup@v2 to commit SHA eae0cfeb286e66ffb5155f1a79b90583a127a68b (v2.4.1)

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Semgrep scan: 26 findings Semgrep scan: 0 findings

Prerequisites

  • Install semgrep if not already installed with pip install semgrep

Verification steps

  • Ensure the semgrep Thrid Party Action Not Pinned to Commit test passed. In your terminal, run semgrep --config="r/yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha.third-party-action-not-pinned-to-commit-sha" - the output should say "Findings: 0 (0 blocking)".
  • Not all jobs can be checked until this PR is merged to develop. For now, we can check these listed below.
    Ex: Click on the "ESLint Review (api-v4)" below and observe job is using the pinned SHA on the details page: image

Post-merge we can check the security-scan job in GitHub Actions for security_scan.yml, example:
https://github.com/linode/manager/actions/runs/16785776661/job/47535731671

And we can check the build job for docs.yml, example:
https://github.com/linode/manager/actions/runs/16785776667/job/47535731564

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bill-akamai bill-akamai self-assigned this Aug 6, 2025
@bill-akamai bill-akamai added the Security Pull requests that address a security vulnerability label Aug 6, 2025
@bill-akamai bill-akamai marked this pull request as ready for review August 6, 2025 20:20
@bill-akamai bill-akamai requested a review from a team as a code owner August 6, 2025 20:20
@bill-akamai bill-akamai requested review from bnussman-akamai and hasyed-akamai and removed request for a team August 6, 2025 20:20
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing703 Passing4 Skipped133m 36s

Details

Failing Tests
SpecTest
restricted-user-details-pages.spec.tsCloud Manager Cypress Tests→restricted user details pages » should disable action elements and buttons in the 'Linodes' details page
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/restricted-user-details-pages.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semgrep output locally ✅

Screenshot 2025-08-12 at 3 09 36 PM

Verification checks in CI ✅

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 12, 2025
@bill-akamai bill-akamai merged commit 9849406 into linode:develop Aug 12, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Security Pull requests that address a security vulnerability

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants