[DI-26394] - Add new flag to control services types in alerts and metrics #12671

ankita-akamai · 2025-08-11T15:04:11Z

Description 📝

Handle new flag to control services types in alerts and metrics in ui.

Changes 🔄

DI-26394: Added new LaunchDarkly flag to control service types in alerts and metrics UI
- Update CloudPulseDashboardSelect.tsx, AlertListing.tsx, ServiceTypeSelect.tsx, AlertReusableComponent.tsx to filter the service types based on truthy props in the new feature flag - aclpServices.
DI-26398: Added/Updated Cypress specs to cover aclpServices LaunchDarkly flags for Alert and Metrics features

Flag Description: aclpServices: enabled prop controls if service needs to be shown in UI and beta prop signifies if service is in beta phase.

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Target release date 🗓️

26 August 2025

Preview 📷

No change in ui -

- Metrics:

Alerts

Listing Select:

Listing alerts:

Create:

How to test 🧪

Verification steps

Navigate to /metrics. Click on 'select a dashboard' autocomplete and verify whether the services - 'linode', 'databases', 'nodebalancers', 'firewalls' are visible.
Navigate to /alerts. Click on 'select a service' autocomplete and verify whether the services - 'linode', 'databases', 'nodebalancers', 'firewalls' are visible.
Click on 'create alert' button. Now, check if services - 'linode', 'databases', 'nodebalancers', 'firewalls' are visible in the 'select a service' dropdown.

If you go to cloud.dev.linode.com, you would see a new service Network LoadBalancer coming up in all of these service select autocompletes, but you wouldn't see that in this pr branch as we have not yet added Network LoadBalancer in our LD flag. This is expected and can be used to check if flag is working properly.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…rics in ui

Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com>

…ags for Alert and Metrics features

ankita-akamai · 2025-08-12T04:49:22Z

@pmakode-akamai I removed all instances of aclpBetaServices flag use in LinodeCreate and LinodeDetail folder, replaced it with aclpServices flag's beta prop.
aclpServices:

Please check and let me know if you would like to use 'enabled' property for all use cases except betachip for which beta prop can still be used.

…details page

ankita-akamai · 2025-08-12T12:33:24Z

@pmakode-akamai I removed all instances of aclpBetaServices flag use in LinodeCreate and LinodeDetail folder, replaced it with aclpServices flag's beta prop. aclpServices:

Please check and let me know if you would like to use 'enabled' property for all use cases except betachip for which beta prop can still be used.

I Updated flag use in linodeCreate and linodeDetail based on the input. @pmakode-akamai .

pmakode-akamai

thanks @ankita-akamai! Looks good to me ✅ - just left a couple of minor comments.

Once UX agrees on the new feature chip for ACLP alerts based on the LD flag for GA, we could consider moving/reusing this util across the app in a follow-up PR

pmakode-akamai · 2025-08-13T07:19:22Z

packages/manager/src/features/Linodes/LinodesDetail/LinodesDetailNavigation.tsx

    {
      chip:
-        aclpBetaServices?.linode?.metrics &&
+        aclpServices?.linode?.metrics?.beta &&


I think this might be a special case (same for the one below) - should we show the beta chip only when the aclp services feature flag is enabled (i.e., enabled takes precedence over beta)? What do you think?

Screen.Recording.2025-08-13.at.12.32.37.PM.mov

Agree, good catch. I will put combined check in this file at both the places.

pmakode-akamai · 2025-08-13T07:31:19Z

packages/manager/cypress/e2e/core/linodes/alerts-create.spec.ts

+          metrics: {
+            beta: false,
+            enabled: false,
+          },


nit: Looks like aclpBetaServices should be updated to aclpServices in the describe block at L462

…mai/manager into feature/HandleAclpServicesFlag

ankita-akamai · 2025-08-13T10:52:34Z

I see that after my above flag combination change(recent commit - 37bc95c), alert-edit.spec is failing, I'm looking into it.

dmcintyr-akamai · 2025-08-13T10:58:40Z

packages/manager/cypress/e2e/core/linodes/alerts-edit.spec.ts

  beforeEach(() => {
    mockAppendFeatureFlags({
-      aclpBetaServices: {
+      aclpServices: {


most of the tests in this file are failing now. these tests are following the logic in packages/shared/src/hooks/useIsLinodeAclpSubscribed.ts. are they failing bc we are moving from beta to GA stage?

I fixed, there was some issue after recent commit for which i commented above. They are passing now. @dmcintyr-akamai

…mai/manager into feature/HandleAclpServicesFlag

linode-gh-bot · 2025-08-13T11:59:40Z

Cloud Manager UI test results

🔺 3 failing tests on test run #9 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`3 Failing`	`715 Passing`	`4 Skipped`	`125m 27s`

Details

Failing Tests
	Spec	Test
❌	`object-storage-objects-multicluster.spec.ts`	Cloud Manager Cypress Tests→Object Storage Multicluster objects » "before all" hook for "can upload, access, and delete objects"
❌	`qemu-reboot-upgrade-notice.spec.ts`	Cloud Manager Cypress Tests→QEMU reboot upgrade notification » should display maintenance banner in 'Linode' landing page when one or more Linodes get impacted.
❌	`smoke-linode-landing-table.spec.ts`	Cloud Manager Cypress Tests→linode landing checks » checks the landing page side menu items

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/notificationsAndEvents/qemu-reboot-upgrade-notice.spec.ts,cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts"

ankita-akamai and others added 16 commits August 11, 2025 16:41

[DI-26394] - Add new flag to control services types in alerts and met…

70d9918

…rics in ui

[DI-26394] - Update type

8267ed6

[DI-26394] - fix eslint issues

9927786

[DI-26394] - Cleanup

ec290d2

[DI-26394] - Remove aclpBetaServices flag

706e4ec

[DI-26394] - Update type

f523b3b

[DI-26394] - Remove fallbacks

d4a297c

[DI-26394] - Update reusable comp as per aclp-dev

2a2606a

[DI-26394] - Update comments

14365a2

[DI-26394] - reuse type

5b653db

upcoming: [DI-26394] - Update comment

b44c9d1

Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com>

[DI-26394] - Make props optional and update test cases

c5f2388

[DI-26394] - Update component

2b07efa

[DI-26394] - Update component

2f3631d

test[DI-26398]: Add/Update spec to cover aclpServices LaunchDarkly fl…

4b67914

…ags for Alert and Metrics features

test[DI-26398]: Add/Update spec to cover aclpServices

67b8c66

github-project-automation bot added this to Cloud Manager Aug 11, 2025

github-project-automation bot moved this to Review in Cloud Manager Aug 11, 2025

test[DI-26398]: Fix typecheck issue

a150a88

ankita-akamai self-assigned this Aug 11, 2025

ankita-akamai added Cloud Pulse - Alerting Cloud Pulse - Dashboards labels Aug 11, 2025

[DI-26394] - remove type assertion

8702688

ankita-akamai marked this pull request as ready for review August 12, 2025 02:49

ankita-akamai requested review from a team as code owners August 12, 2025 02:49

ankita-akamai requested review from cpathipa and dmcintyr-akamai and removed request for a team August 12, 2025 02:49

ankita-akamai requested a review from pmakode-akamai August 12, 2025 02:49

[DI-26394] - Add changeset

abb91dd

ankita-akamai requested a review from nikhagra-akamai August 12, 2025 04:52

cpathipa approved these changes Aug 12, 2025

View reviewed changes

upcoming:[DI-26394]: Use appropriate flag prop for linode create and …

30a3ca9

…details page

Merge branch 'develop' into feature/HandleAclpServicesFlag

de48fe6

pmakode-akamai approved these changes Aug 13, 2025

View reviewed changes

github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 13, 2025

pmakode-akamai added the SDET Approval Needed label Aug 13, 2025

ankita-akamai and others added 3 commits August 13, 2025 15:02

[DI-26394] - update flag check and e2e test desc

37bc95c

Merge branch 'feature/HandleAclpServicesFlag' of github.com:ankitaaka…

f543470

…mai/manager into feature/HandleAclpServicesFlag

Merge branch 'develop' into feature/HandleAclpServicesFlag

1e74c59

dmcintyr-akamai reviewed Aug 13, 2025

View reviewed changes

ankita-akamai added 2 commits August 13, 2025 16:38

upcoming:[DI-26394]: Update flag correctly

598ba57

Merge branch 'feature/HandleAclpServicesFlag' of github.com:ankitaaka…

b565a06

…mai/manager into feature/HandleAclpServicesFlag

dmcintyr-akamai self-requested a review August 13, 2025 13:29

dmcintyr-akamai approved these changes Aug 13, 2025

View reviewed changes

nikhagra-akamai merged commit 8c4211e into linode:develop Aug 13, 2025
34 of 35 checks passed

github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 13, 2025

ankita-akamai removed the SDET Approval Needed label Aug 14, 2025

pmakode-akamai added the ACLP Integration CI (Cloud Interfaces) Support for CC (Core Compute) CloudPulse Integration label Aug 20, 2025

This was referenced Aug 21, 2025

Release v1.149.0 - release → staging #12741

Merged

Release v1.149.0 - staging → master #12751

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DI-26394] - Add new flag to control services types in alerts and metrics #12671

[DI-26394] - Add new flag to control services types in alerts and metrics #12671

Uh oh!

ankita-akamai commented Aug 11, 2025 •

edited

Loading

Uh oh!

ankita-akamai commented Aug 12, 2025

Uh oh!

ankita-akamai commented Aug 12, 2025

Uh oh!

pmakode-akamai left a comment

Uh oh!

pmakode-akamai Aug 13, 2025

Uh oh!

ankita-akamai Aug 13, 2025

Uh oh!

pmakode-akamai Aug 13, 2025

Uh oh!

ankita-akamai commented Aug 13, 2025 •

edited

Loading

Uh oh!

dmcintyr-akamai Aug 13, 2025

Uh oh!

ankita-akamai Aug 13, 2025 •

edited

Loading

Uh oh!

linode-gh-bot commented Aug 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

[DI-26394] - Add new flag to control services types in alerts and metrics #12671

[DI-26394] - Add new flag to control services types in alerts and metrics #12671

Uh oh!

Conversation

ankita-akamai commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Scope 🚢

Target release date 🗓️

Preview 📷

- Metrics:

Alerts

How to test 🧪

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

ankita-akamai commented Aug 12, 2025

Uh oh!

ankita-akamai commented Aug 12, 2025

Uh oh!

pmakode-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

pmakode-akamai Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

ankita-akamai Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

pmakode-akamai Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

ankita-akamai commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmcintyr-akamai Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

ankita-akamai Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Aug 13, 2025

Cloud Manager UI test results

🔺 3 failing tests on test run #9 ↗︎

Details

Troubleshooting

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ankita-akamai commented Aug 11, 2025 •

edited

Loading

ankita-akamai commented Aug 13, 2025 •

edited

Loading

ankita-akamai Aug 13, 2025 •

edited

Loading