Change: [DI-26395] - Update filters to use the resources from useQuery cache in CloudPulse metrics #12678
Conversation
…nce_call # Conflicts: # packages/manager/src/features/CloudPulse/Alerts/AlertRegions/AlertRegions.tsx # packages/manager/src/features/CloudPulse/shared/CloudPulseResourcesSelect.tsx
| const getAllFirewallsRequest = () => | ||
| getAll<Firewall>((passedParams, passedFilter) => | ||
| getFirewalls(passedParams, passedFilter), | ||
| const getAllFirewallsRequest = ( |
There was a problem hiding this comment.
FYI - Since we need to pass order by and order filters , need this handling in firewall
|
|
||
| const supportedRegionIds = getSupportedRegionIds(regions, serviceType); | ||
| const xFilterToBeApplied: Filter | undefined = React.useMemo(() => { | ||
| if (serviceType === 'firewall') { |
There was a problem hiding this comment.
We don't need to pass any filters in the alert side for firewalls
venkymano-akamai
requested review from
bill-akamai,
dmcintyr-akamai and
mjac0bs
and removed request for
a team
|
i do see fewer identical requests, so it looks like it works, but why is this test (where you removed some of the UI selections) still making 4 identical requests? it is making fewer requests but does it continue making requests in case of failure? |
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
- Observed the current behavior with multiple calls.
- On this branch, confirmed:
- ✅ One GET call to get the list of instances.
- ✅ Filters will appear and upon selection, no other instance calls are made and metrics appear.
- ✅ This is consistence across the different resource types.
yes, it makes four retries to show error message, default behaviour of useQuery hook |
Cloud Manager UI test results🎉 724 passing tests on test run #7 ↗︎
|
|
Merging this since it has enough approvals and all checks are passing |
4 participants
Description 📝
In CloudPulse metrics page for DBaaS service dashboard, a max of 5 API calls are made to fetch the clusters, mainly due to difference in the filters we pass to the API.
In this set of changes, we have reduced the instances call to only one, immediately after selecting a dashboard. In the subsequent filter calls / components we use the same use Hook with same filter and apply the filters offline. This helps in better user experience as well reduction in the number of calls we make. This change is applicable for all service types.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
15-08-2025 on Alpha
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.🔒 Use the Mask Sensitive Data setting for security.
💡 For changes requiring multiple steps to validate, prefer a video for clarity.
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅