Skip to content

Conversation

@kagora-akamai
Copy link
Contributor

@kagora-akamai kagora-akamai commented Aug 12, 2025

Description 📝

DataStream: Search and select inputs for streams and destinations tables

Changes 🔄

  • In streams table:
    • Text input: Search for a Stream
    • Select: filter by Status
  • In destinations table:
    • Text input: Search for a Destination

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • No customers / Not applicable

Target release date 🗓️

September 2025

Preview 📷

Before After
Screenshot 2025-08-12 at 13 31 32 Screenshot 2025-08-12 at 12 40 46
Screenshot 2025-08-12 at 13 31 45 Screenshot 2025-08-12 at 12 41 01

How to test 🧪

Prerequisites

  • Open Local Dev Tools
  • Enable MSW, set Base Preset to CRUD
  • Apply

Verification steps

  • Destinations:

    • Navigate to datastream/destinations
    • Create a new destination if there is none (Click on Create Destination, fill the form, submit with Create Destination, on success you will be redirected to datastream/destinations)
    • Fill search input
    • Label should appear in url query
    • Open Local Dev Tools > React Query > Select last datastream destinations query - See chosen values are in query details
  • Streams:

    • Navigate to datastream/streams
    • Create a new stream if there is none (Click on Create Stream, fill the form, choose existing Destination, submit with Create Stream, on success you will be redirected to datastream/streams)
    • Fill search input, select status
    • Both values should appear in url query
    • Open Local Dev Tools > React Query > Select last datastream streams query - See chosen values are in query details
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@kagora-akamai kagora-akamai self-assigned this Aug 12, 2025
@kagora-akamai kagora-akamai force-pushed the feature/DPS-34193-add-search-and-select-to-stream-and-destinations-table branch from 2664569 to 4e4cf14 Compare August 12, 2025 11:35
@kagora-akamai kagora-akamai marked this pull request as ready for review August 12, 2025 11:39
@kagora-akamai kagora-akamai requested a review from a team as a code owner August 12, 2025 11:39
@kagora-akamai kagora-akamai requested review from bill-akamai and hana-akamai and removed request for a team August 12, 2025 11:39
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing703 Passing4 Skipped137m 39s

Details

Failing Tests
SpecTest
smoke-linode-landing-table.spec.tsCloud Manager Cypress Tests→linode landing checks » checks the landing page side menu items
restricted-user-details-pages.spec.tsCloud Manager Cypress Tests→restricted user details pages » should disable action elements and buttons in the 'Linodes' details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts,cypress/e2e/core/account/restricted-user-details-pages.spec.ts"

Copy link
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kagora-akamai I'm confused about what to do after reaching datastream/streams/.
Should this be done somewhere while creating a stream or should there be streams available from the mock data (I don't see any)?

Fill search input, select status

Would you be able to share a video?

@kagora-akamai
Copy link
Contributor Author

kagora-akamai commented Aug 13, 2025

@kagora-akamai I'm confused about what to do after reaching datastream/streams/. Should this be done somewhere while creating a stream or should there be streams available from the mock data (I don't see any)?

Fill search input, select status

Would you be able to share a video?

Hi @bill-akamai!

Sorry for the confusion. You need to create a new Stream for the view in datastream/streams to change into table. Before that create a new Destination in Destinations tab, it will be needed for creating new stream.

I've updated the commit description.

Copy link
Contributor

@bill-akamai bill-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kagora-akamai - I was able to see the search/select inputs. Assuming the actual filtering logic will be upcoming so approving the presentation of it 👍

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 14, 2025
@hana-akamai hana-akamai added the Approved Multiple approvals and ready to merge! label Aug 14, 2025
@mduda-akamai mduda-akamai merged commit 7a8417c into linode:develop Aug 18, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Logs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants