-
Notifications
You must be signed in to change notification settings - Fork 391
upcoming: [DPS-34193] - Add search and select to streams and destinations table #12679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [DPS-34193] - Add search and select to streams and destinations table #12679
Conversation
2664569 to
4e4cf14
Compare
Cloud Manager UI test results🔺 2 failing tests on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts,cypress/e2e/core/account/restricted-user-details-pages.spec.ts" |
||||||||||||||||||||
bill-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kagora-akamai I'm confused about what to do after reaching datastream/streams/.
Should this be done somewhere while creating a stream or should there be streams available from the mock data (I don't see any)?
Fill search input, select status
Would you be able to share a video?
Hi @bill-akamai! Sorry for the confusion. You need to create a new Stream for the view in I've updated the commit description. |
bill-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kagora-akamai - I was able to see the search/select inputs. Assuming the actual filtering logic will be upcoming so approving the presentation of it 👍
Description 📝
DataStream: Search and select inputs for streams and destinations tables
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
September 2025
Preview 📷
How to test 🧪
Prerequisites
Verification steps
Destinations:
datastream/destinationsCreate Destination, fill the form, submit withCreate Destination, on success you will be redirected todatastream/destinations)Streams:
datastream/streamsCreate Stream, fill the form, choose existing Destination, submit withCreate Stream, on success you will be redirected todatastream/streams)Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
📱 Providing mobile support
As an Author, before moving this PR from Draft to Open, I confirmed ✅