-
Notifications
You must be signed in to change notification settings - Fork 393
[UIE-9084] - Enable view payments based on new permissions #12682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| if (!paymentMethods || paymentMethods?.length == 0) { | ||
| if (!paymentMethods || paymentMethods?.length === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just because!
@abailly-akamai Can you clarify - what does this mean? |
|
@mjac0bs Sorry it wasn't clear, this is new linguo to me as well. I updated the description to "Have a non-akamai DevCloud account" The reason is needing to have a payment method on the account, which employees account don't have. I was given credentials for one of those by @kwojtowiakamai, but I am unsure how to create such account at the moment outside of using devenv/devcloud |
kwojtowiakamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mjac0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jaalah-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mjac0bs for confirmation screenshot with account. Code changes look solid for this one.
Cloud Manager UI test results🔺 2 failing tests on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts" |
||||||||||||||||||||
|
|




Description 📝
Small fix to ensure fetching payment methods is based on the new IAM RBAC model, rather than grants alone.
Changes 🔄
enabledlogic foruseAllPaymentMethodsQueryto prop and pass new RBAC permissions to itScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
8/26/2025
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
account with only
account_viewerpermissionsVerification steps
account with only
account_viewerpermissionsNavigate to /account/billing
Confirm the Payment Methods panel features the payment methods on the account
Confirm no regression for other users
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅