Skip to content

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Aug 12, 2025

Description 📝

Small fix to ensure fetching payment methods is based on the new IAM RBAC model, rather than grants alone.

Changes 🔄

  • Move enabled logic for useAllPaymentMethodsQuery to prop and pass new RBAC permissions to it

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

8/26/2025

Preview 📷

Before After
Screenshot 2025-08-12 at 16 23 54 Screenshot 2025-08-12 at 16 21 57

How to test 🧪

Prerequisites

  • Have a non-akamai DevCloud account (we need at least one payment method on the account)

Reproduction steps

account with only account_viewer permissions

  • Navigate to /account/billing
  • Notice the Payment Methods panel says "No payments methods have been specified for this account"

Verification steps

account with only account_viewer permissions

  • Navigate to /account/billing

  • Confirm the Payment Methods panel features the payment methods on the account

  • Confirm no regression for other users

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai marked this pull request as ready for review August 12, 2025 14:24
@abailly-akamai abailly-akamai requested a review from a team as a code owner August 12, 2025 14:24
@abailly-akamai abailly-akamai requested review from coliu-akamai and mjac0bs and removed request for a team August 12, 2025 14:24
}

if (!paymentMethods || paymentMethods?.length == 0) {
if (!paymentMethods || paymentMethods?.length === 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just because!

@mjac0bs
Copy link
Contributor

mjac0bs commented Aug 12, 2025

Have two PayGo IAM account

@abailly-akamai Can you clarify - what does this mean?

@abailly-akamai
Copy link
Contributor Author

@mjac0bs Sorry it wasn't clear, this is new linguo to me as well. I updated the description to "Have a non-akamai DevCloud account"

The reason is needing to have a payment method on the account, which employees account don't have. I was given credentials for one of those by @kwojtowiakamai, but I am unsure how to create such account at the moment outside of using devenv/devcloud

Copy link

@kwojtowiakamai kwojtowiakamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Payment Methods are visible for the users with the account_admin role (the list_payment_methods permission). No regression for non-IAM users.
image
image

@aaleksee-akamai aaleksee-akamai self-requested a review August 14, 2025 08:27
@jaalah-akamai jaalah-akamai requested review from jaalah-akamai and removed request for mjac0bs August 14, 2025 15:07
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the login information for a "PayGo" devcloud admin and non-admin account from Kamil.

Devcloud This Branch
Screenshot 2025-08-14 at 9 23 29 AM Screenshot 2025-08-14 at 9 22 28 AM

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Aug 14, 2025
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjac0bs for confirmation screenshot with account. Code changes look solid for this one.

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Aug 14, 2025
@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 14, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing715 Passing5 Skipped129m 42s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » "before all" hook for "can create and delete object storage buckets"
linode-storage.spec.tsCloud Manager Cypress Tests→linode storage tab » delete disk

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts"

@jaalah-akamai
Copy link
Contributor

linode-storage.spec.ts - known issue
object-storage.e2e.spec.ts - flaky, ran this about 5 times locally with some passing and other failing for various reasons

@jaalah-akamai jaalah-akamai merged commit 14c2f36 into linode:develop Aug 15, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants