fix: [UIE-9063] - IAM Add User FE validation and schema improvement #12687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
requested review from
hana-akamai and
hasyed-akamai
and removed request for
a team
abailly-akamai
commented
Aug 13, 2025
| onClick={() => setIsCreateDrawerOpen(true)} | ||
| sx={{ | ||
| maxWidth: '120px', | ||
| }} |
Contributor
Author
There was a problem hiding this comment.
This was really bothering me!
| Before | After |
|---|---|
 |
 |
jaalah-akamai
approved these changes
Aug 13, 2025
hana-akamai
approved these changes
Aug 13, 2025
Contributor
hana-akamai
left a comment
hana-akamai
left a comment
There was a problem hiding this comment.
It looks like devcloud has some issues right now so I wasn't able to create an actual user but validation looks good
Unrelated, I noticed an issue with bad grant calls for each user so I created M3-10478 to look into that
hana-akamai
added
Approved
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-storage.spec.ts" |
|||||||||||||||||
This was referenced Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The front-end validation was missing from the IAM
CreateUserdrawer, resulting on waiting for an API response and getting a rather unhelpful generic response ("Invalid username or email address").I added the missing yup resolver (which is also used in the legacy /account/users CreateUser drawer). In addition I improved the error messaging and validation schema based on what the API does, see:
ApiNext>validators>username_validator.pyChanges 🔄
CreateUserdrawerScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
8/26/2025
Preview 📷
How to test 🧪
Prerequisites
IAM enabled account
Reproduction steps
Verification steps
💡 in addition:
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅