-
Notifications
You must be signed in to change notification settings - Fork 390
fix: [M3-10497], [M3-10495], [M3-10493], [M3-10494] - Fix Invoice pagination, unwanted hyphen in service transfers breadcrumb, restricted message in quotas and open make a payment drawer when IAM nav is enabled #12726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ed and Quotas is disabled
|
@cpathipa Can you add the Urgent label if this is needed for 8/26? |
jdamore-linode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chandra! Aside from the Quotas feature flag behavior, everything is looking good to me 👍 I'm hoping you can take a second look at the Quotas change because I don't think showing a banner in that case makes much UX sense or is consistent with how we gate other feature flags
mjac0bs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the IAM Primary Nav changes flag on:
✅ Verified upon clicking pagination buttons in the billing invoice list, users should navigate to the desired page. (M3-1049)
✅ Verify clicking "Make a Payment" should open the "Make a Payment" drawer. (M3-10495)
- Also verified the Add Payment and Edit Billing Contact Info drawers
✅ Verified service transfers details page breadcrumb contains now hyphen when Iam nav flag is enabled. (M3-10494)
✅ Verified when navigating to the Quotas page while the feature is disabled (limitsEvolution), the user should not be able to see restricted message in Quotas page. (M3-10493)
- Left one comment about the copy, but otherwise this looked good.
Thanks @cpathipa, approving pending tests pass.
Cloud Manager UI test results🔺 2 failing tests on test run #10 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts,cypress/e2e/core/notificationsAndEvents/events-fetching.spec.ts" |
||||||||||||||||||||
Description 📝
This PR address the bugs
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
8/26
Preview 📷
How to test 🧪
Reproduction steps
M3-10497 Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅