Skip to content

Conversation

@bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Sep 5, 2025

Description 📝

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Screenshot 2025-09-05 at 3 47 16 PM Screenshot 2025-09-05 at 3 42 51 PM
#12824 will cause tmp to be bumped to 0.2.5, thus resolving https://github.com/linode/manager/security/dependabot/170

How to test 🧪

  • Checkout this PR
  • Run pnpm i
  • Run pnpm why -r tmp to check what versions of tmp are installed
    • Verify this PR results in inquirer no longer depending on tmp
  • Verify that our tooling that uses inquirer still works (for example, try pnpm changeset and verify it still works)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Note

No changeset included because this only touches scripts, which is not versioned

@bnussman-akamai bnussman-akamai self-assigned this Sep 5, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 5, 2025 19:52
@bnussman-akamai bnussman-akamai requested review from mjac0bs and removed request for a team September 5, 2025 19:52
@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Sep 5, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing744 Passing6 Skipped39m 1s

Details

Failing Tests
SpecTest
resize-linode.spec.tsCloud Manager Cypress Tests→resize linode » resizes a linode by decreasing size

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/resize-linode.spec.ts"

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Confirmed inquirer no longer depends on tmp
pnpm changeset still works

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Sep 8, 2025
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as Hana. ✅ 🚢

image

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Sep 8, 2025
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 8, 2025
@bnussman-akamai bnussman-akamai merged commit b7d1b29 into linode:develop Sep 8, 2025
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants