tech-story - [UIE-9306]: Improve user seeding (follow up) #12978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
added
the
IAM Delegation
abailly-akamai
force-pushed
the
UIE-9306-fix
branch
2 times, most recently
from
f0e68b6 to
2b61ffe
Compare
abailly-akamai
force-pushed
the
UIE-9306-fix
branch
from
fd5a7f9 to
59faae5
Compare
abailly-akamai
requested review from
aaleksee-akamai,
Copilot and
mpolotsk-akamai
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves user seeding functionality by separating default and parent/child user seeding into distinct seeders, fixing account switching bugs, and ensuring better mock data integrity.
- Split user seeding into two distinct seeders: default users and parent users with child accounts/delegations
- Removed dependency on actual profile data from API calls during seeding
- Enhanced parent user seeding to create comprehensive hierarchical structures with child accounts and delegate users
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/manager/src/mocks/types.ts | Added new seeder IDs for default and parent user types |
| packages/manager/src/mocks/presets/crud/seeds/utils.ts | Updated cleanup logic to handle both user seeder types |
| packages/manager/src/mocks/presets/crud/seeds/users.ts | Split into separate seeders and removed API dependency |
| packages/manager/src/mocks/presets/crud/seeds/index.ts | Updated exports to include both user seeders |
Comments suppressed due to low confidence (1)
packages/manager/src/mocks/presets/crud/seeds/users.ts:1
- The original 'users:crud' case has been removed from the switch statement, but the corresponding case should be preserved or explicitly handled to maintain backward compatibility.
import { childAccountFactory } from '@linode/utilities';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts" |
||||||||||||||||||||
bnussman-akamai
approved these changes
Oct 14, 2025
| const userAccountPermissionsEntries: UserAccountPermissionsEntry[] = []; | ||
| const userEntityPermissionsEntries: UserEntityPermissionsEntry[] = []; | ||
|
|
||
| userSeeds.forEach((user) => { |
Member
There was a problem hiding this comment.
optional style: I see a mix of forEach and for (const x of y). Maybe we could prefer one over another
Contributor
Author
There was a problem hiding this comment.
Yeah that's fair. I'll probably leave this as is cause this code really isn't the best overall granted it is not optimized for our users. One day someone may clean that up but for now we just really care that it works for devs 👍
aaleksee-akamai
approved these changes
Oct 15, 2025
corya-akamai
pushed a commit
to corya-akamai/manager
that referenced
this pull request
Dec 8, 2025
* distinctive seeding * handle dupe records * Update packages/manager/src/mocks/presets/crud/seeds/utils.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * lint --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Follow up to #12957
Ensuring mock data integrity and facilitate user seeding.
👉 No changeset needed, it's a follow up to work already implemented and previously committed.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
This PR does not affect client side code
How to test 🧪
Prerequisites
Verification steps
From either a Parent or Child account,
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅