-
Notifications
You must be signed in to change notification settings - Fork 390
Added: [DI-29070] - New feature marker in navigation menu and primary breadcrumbs of CloudPulse metrics #13230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: [DI-29070] - New feature marker in navigation menu and primary breadcrumbs of CloudPulse metrics #13230
Conversation
santoshp210-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pmakode-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
This is not a blocker, but I wanted to point out that toggling the flag from DevTools for the CloudPulse feature-related Chips does not immediately reflect in the PrimaryNav unless I reload the page/app, although the Breadcrumb Suffix Feature Chip works as expected. Other features, like IAM in PrimaryNav, work as expected.
See
Screen.Recording.2026-01-01.at.2.32.32.PM.mov
Approving pending resolution of the one minor comment I left.
| hide: !isACLPEnabled, | ||
| to: '/metrics', | ||
| isBeta: flags.aclp?.beta, | ||
| isNew: flags.aclp?.new, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a condition similar to L279 -- show the new feature chip only when the beta flag is not enabled, to avoid potentially displaying two chips at the same time, like this:
Cloud Manager UI test results🔺 2 failing tests on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/vpc/vpc-linodes-update.spec.ts" |
||||||||||||||||||||
|
merging this, since it has enough approvals and cypress is unrelated The minor comment from @pmakode-akamai is also addressed |

Description 📝
Add New feature marker in navigation menu and primary breadcrumbs of CloudPulse metrics
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️ Next Release
Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅