upcoming: [DI-29061] - Notification Channel Show Details - Associated Alerts #13294
+640
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data-qa-alert-link | ||
| to={`/alerts/definitions/detail/${service_type}/${id}`} | ||
| > | ||
| {label} |
Contributor
There was a problem hiding this comment.
hope we are fine displaying the label with whatever case we are receiving and no need to convert to some custom cases?
Contributor
Author
There was a problem hiding this comment.
Yes, Alert labels should not be transformed or converted in any other way.
| "@linode/api-v4": Upcoming Features | ||
| --- | ||
|
|
||
| New type, request to fetch alerts associated to a notification channel ([#13294](https://github.com/linode/manager/pull/13294)) |
Contributor
There was a problem hiding this comment.
Suggested change
| New type, request to fetch alerts associated to a notification channel ([#13294](https://github.com/linode/manager/pull/13294)) | |
| New type `NotificationChannelAlerts`, request `getAlertsByNotificationChannelId` to fetch alerts associated to a notification channel ([#13294](https://github.com/linode/manager/pull/13294)) |
venkymano-akamai
approved these changes
Jan 20, 2026
Contributor
venkymano-akamai
left a comment
venkymano-akamai
left a comment
There was a problem hiding this comment.
Approved pending changeset change
ankita-akamai
approved these changes
Jan 20, 2026
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/images/search-images.spec.ts" |
||||||||||||||||||||
Contributor
Author
|
Failing tests are not related to the PR changes. Merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Covers the Associated Alerts section of the Notification Channel Show Details Page
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
28th Jan
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.🔒 Use the Mask Sensitive Data setting for security.
💡 For changes requiring multiple steps to validate, prefer a video for clarity.
FIGMA
localhost
No alert case
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅