feat: [UIE-10051] - IAM Delegation: allow sending an empty array #13300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaleksee-akamai
added
the
IAM Delegation
…legation with empty array, update the delegations after reopening a drawer
aaleksee-akamai
commented
Jan 21, 2026
| watch, | ||
| } = form; | ||
|
|
||
| watch('users'); |
Contributor
Author
There was a problem hiding this comment.
wasn't used
aaleksee-akamai
commented
Jan 21, 2026
| } = form; | ||
|
|
||
| watch('users'); | ||
| // Reinitialize form values when the drawer opens or delegated users change |
Contributor
Author
There was a problem hiding this comment.
add the similar logic as for UpdateEntitiesDrawer
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
| React.useEffect(() => { | ||
| if (!open) return; | ||
| reset({ users: formattedCurrentUsers }, { keepDirtyValues: true }); | ||
| }, [open, formattedCurrentUsers, reset]); |
Contributor
There was a problem hiding this comment.
I don't like adding a useEffect to update a form state. It is an anti-pattern. I am surprised you need this as reset() is called in handleClose()?
useForm should have all the method available or I think you could add a key to the FormProvider for instance:
<FormProvider {...form} key={`${delegation?.euuid}-${open}`}>
mpolotsk-akamai
approved these changes
Jan 22, 2026
Contributor
mpolotsk-akamai
left a comment
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Works as expected. Able to unassign all delegations.
| onClose: () => void; | ||
| userOptions: UserOption[]; | ||
| } | ||
| export const UpdateDelegationForm = ({ |
Contributor
There was a problem hiding this comment.
Looks much cleaner now 👍
abailly-akamai
approved these changes
Jan 22, 2026
This was referenced Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR removes restriction to update user delegation with empty array and fixes an issue where the delegations weren’t updated after reopening a drawer
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-21.at.12.57.39.PM.mov
Screen.Recording.2026-01-21.at.12.55.20.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
go to /iam/delegations
update delegations by removing all users
go to /iam/delegations
update delegations for an account
open a drawer for the same account
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅