fix: [UIE-10329] - UpdateDelegationDrawer Follow up#13446
Open
abailly-akamai wants to merge 1 commit intolinode:developfrom
Open
fix: [UIE-10329] - UpdateDelegationDrawer Follow up#13446abailly-akamai wants to merge 1 commit intolinode:developfrom
abailly-akamai wants to merge 1 commit intolinode:developfrom
Conversation
kwojtowiakamai
approved these changes
Mar 2, 2026
| } | ||
| label={'Delegate Users'} | ||
| loading={isFetching} | ||
| loading={isFetching || isFetchingAllUsers} |
Contributor
There was a problem hiding this comment.
nit: if you clear an input, then start typing - first, you'll see you have no options and only then a loading spinner and later a result
Contributor
aaleksee-akamai
left a comment
There was a problem hiding this comment.
I like this approach, looks good!
aaleksee-akamai
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Screen.Recording.2026-03-02.at.2.35.32.PM.mov
@abailly-akamai, I’m seeing a 500 error when clearing the select box and selecting only a few users (e.g., 3). Selecting all users works correctly.
Additionally, the “+23” count is incorrect during loading when selecting all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
In #13441 I implemented an infinite query but omitted to handle the case where the user does a Select All, in which case we need to fetch all records.
We're still only fetching the first 25 users when opening the Drawer, so performance isn't affected. It's only if we decide to Select all of them that the expensive query happens, which is a decent workaround.
Changes 🔄
onSelectAllClickprop to ourAutocomplete(not affecting current usage)SelectAllClickScope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-02-27.at.14.41.04.mov
How to test 🧪
Prerequisites
Have a large parent/child account (many users - ask for being added if not available)
Verification steps
/iam/delegationsand Click Select ALL in the delegation AutocompleteAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅