Skip to content

fix: [UIE-10308] - IAM Parent/Child - SwitchAccount Drawer: hide search if no child account#13464

Merged
abailly-akamai merged 6 commits intolinode:developfrom
abailly-akamai:UIE-10308
Mar 9, 2026
Merged

fix: [UIE-10308] - IAM Parent/Child - SwitchAccount Drawer: hide search if no child account#13464
abailly-akamai merged 6 commits intolinode:developfrom
abailly-akamai:UIE-10308

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Mar 4, 2026

Description 📝

Small PR to hide the search bar in the SwitchAccountDrawer if there no child account to search for

Changes 🔄

List any change(s) relevant to the reviewer.

  • Hide the search bar in the SwitchAccountDrawer if there no child account to search for

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Screenshot 2026-03-04 at 15 26 08 Screenshot 2026-03-04 at 15 25 57

How to test 🧪

Prerequisites

An IAM parent/child account

Reproduction steps

Verification steps

  • Ensure the current user isn't added to any delegation
  • ✅ confirm the search fields is no longer displayed
  • ✅ confirm no regression when added back to a child account delegation (esp while searching)
  • ✅ confirm no regression with a legacy parent/child account
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai self-assigned this Mar 4, 2026
@abailly-akamai abailly-akamai added IAM (Identity & Access Management) IAM Delegation Implementing the new Parent/Child delegation UI labels Mar 4, 2026
@abailly-akamai abailly-akamai marked this pull request as ready for review March 4, 2026 14:30
@abailly-akamai abailly-akamai requested a review from a team as a code owner March 4, 2026 14:30
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the verification steps. LGTM ✅

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

From a UX perspective, is it a good or bad thing that we are eagerly hiding things?
As a user, I usually prefer to see the full experience (even if it is disabled) so that I know what the drawer will allow me to do in the future once I have access

For example:
Image

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 4, 2026
@abailly-akamai
Copy link
Contributor Author

@bnussman-akamai I raised this exact concern in the ticket - you can check the convo there. UX ruled in favor of the approach in this PR, which I also initially disagreed with. Not sure this is worth arguing a lot more over but including @tzmiivsk-akamai in this convo in case there's reconsideration after another concern is raised.

@tzmiivsk-akamai
Copy link

I’m still convinced that removing extra information here will reduce cognitive load and visual noise. For the empty state, we don’t need the search and the description.
However, @bnussman-akamai ’s example made me realize that it would be more appropriate to use the empty state from ADS here (I'm attaching a screenshot and the Figma link).
Additionally, I’ve added a Cancel button, as it was somehow missing from this drawer.
image

@bnussman-akamai
Copy link
Member

That sounds good to me. Thanks @abailly-akamai & @tzmiivsk-akamai

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 3 failing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
3 Failing869 Passing11 Skipped38m 5s

Details

Failing Tests
SpecTest
object-storage.e2e.spec.tsCloud Manager Cypress Tests→object storage end-to-end tests » can create and delete object storage buckets
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Parent » can switch from Proxy user back to Parent account user from Billing page
account-switching.spec.tsCloud Manager Cypress Tests→Parent/Child account switching→From Child to Child » can switch to another Child account as a Proxy user

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/parentChild/account-switching.spec.ts"

@abailly-akamai abailly-akamai merged commit 07a5ee4 into linode:develop Mar 9, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI IAM (Identity & Access Management)

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

6 participants