-
Notifications
You must be signed in to change notification settings - Fork 401
change: [DPS-41857] - Logs: Add new statuses - deactivating, failed #13551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
adb961b
65e34c7
6ec0fb9
1a6a04e
b3dd4ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Added | ||
| --- | ||
|
|
||
| New stream statuses - deactivating, failed ([#13551](https://github.com/linode/manager/pull/13551)) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,12 +77,23 @@ export const StreamForm = (props: StreamFormProps) => { | |
| control, | ||
| name: 'stream.status', | ||
| }); | ||
|
|
||
| const isStreamStatusBlocking = | ||
| !!selectedStreamStatus && | ||
| ( | ||
| [ | ||
| streamStatus.Provisioning, | ||
| streamStatus.Deactivating, | ||
| streamStatus.Failed, | ||
| ] as StreamStatus[] | ||
| ).includes(selectedStreamStatus); | ||
|
|
||
| const submitButtonTooltip = useMemo( | ||
| () => | ||
| selectedStreamStatus === streamStatus.Provisioning | ||
| ? 'You cannot save changes while the stream is provisioning.' | ||
| isStreamStatusBlocking | ||
| ? `You cannot save changes while the stream status is ${selectedStreamStatus}` | ||
| : undefined, | ||
| [selectedStreamStatus] | ||
| [isStreamStatusBlocking, selectedStreamStatus] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It must be included in array, cause both are used in the useMemo. |
||
| ); | ||
|
|
||
| useEffect(() => { | ||
|
|
@@ -212,8 +223,7 @@ export const StreamForm = (props: StreamFormProps) => { | |
| <Grid size={{ lg: 3, md: 12, sm: 12, xs: 12 }}> | ||
| <FormSubmitBar | ||
| blockSubmit={ | ||
| selectedStreamStatus === streamStatus.Provisioning || | ||
| !selectedDestinations?.length | ||
| isStreamStatusBlocking || !selectedDestinations?.length | ||
| } | ||
| connectionTested={destinationVerified} | ||
| destinationType={destination?.type} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New pendo Ids to be added to: https://docs.google.com/spreadsheets/d/1_0eldFGu6nnzoQ3JP5rHLmtY1SGjgpxLEOT8qgf1Xmw/edit?gid=1479039708#gid=1479039708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added