Skip to content

Override CMR flag so that it's always true #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnwcallahan merged 3 commits into from
Dec 10, 2020
Merged

Override CMR flag so that it's always true #7165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05dabbc
Override CMR flag
johnwcallahan Dec 1, 2020
4cdf0c0
Merge branch 'develop' into feature/release-cmr
johnwcallahan Dec 9, 2020
4e07f0d
Clean up
johnwcallahan Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/manager/src/containers/withFeatureFlagConsumer.container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ export const withFeatureFlagConsumer = (
flags: {
// Real LD flags from `withLDConsumer()`.
...this.props.flags,
// @todo: REMOVE BEFORE MERGE
// !!! Override the CMR flag so that it's officially "released" !!!!
// @todo: clean up all conditional logic based on this flag.
cmr: true,
// Mock flags from Redux.
...this.props.mockFlags
Expand Down
3 changes: 2 additions & 1 deletion packages/manager/src/hooks/useFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ export const useFlags = () => {

return {
...flags,
// @todo: REMOVE BEFORE MERGE
// !!! Override the CMR flag so that it's officially "released" !!!!
// @todo: clean up all conditional logic based on this flag.
cmr: true,
...mockFlags
};
Expand Down