Fix: Travis builds failing (Create VLAN tests)#7181
Merged
Jskobos merged 2 commits intolinode:developfrom Dec 7, 2020
Jskobos:M3-remove-vlan-create-tests
Merged
Fix: Travis builds failing (Create VLAN tests)#7181Jskobos merged 2 commits intolinode:developfrom Jskobos:M3-remove-vlan-create-tests
Jskobos merged 2 commits intolinode:developfrom
Jskobos:M3-remove-vlan-create-tests
Conversation
For reasons unknown, VLANs are no longer included in the /regions capability list. Removing these tests until the feature stabilizes (it's likely the create vlan dialog will be removed, so maintaining the tests is not worth it for now)
Jskobos
changed the title
johnwcallahan
approved these changes
Dec 7, 2020
tiffwong
approved these changes
Dec 7, 2020
ndukatz
pushed a commit
to ndukatz/manager
that referenced
this pull request
Dec 7, 2020
* Remove broken VLAN create dialog tests For reasons unknown, VLANs are no longer included in the /regions capability list. Removing these tests until the feature stabilizes (it's likely the create vlan dialog will be removed, so maintaining the tests is not worth it for now) * Update cached data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For reasons unknown, VLANs are no longer included in the /regions
capability list. Removing these tests until the feature stabilizes
(it's likely the create vlan dialog will be removed, so maintaining the
tests is not worth it for now)
Also updated our cached data since it's a little stale