Address feedback from #7180#7185
Merged
johnwcallahan merged 2 commits intolinode:developfrom Dec 10, 2020
Merged
Conversation
- Main Content padding from md to lg breakpoint - No loading icons in search bar
tiffwong
reviewed
Dec 8, 2020
| className={classNames({ | ||
| [classes.icon]: true, | ||
| ['loading']: loading | ||
| [classes.icon]: true |
Contributor
There was a problem hiding this comment.
This can probably be simplified to className={classes.icon}
tiffwong
approved these changes
Dec 8, 2020
Contributor
tiffwong
left a comment
tiffwong
left a comment
There was a problem hiding this comment.
Hooray for things finally coming together! We should go in and remove all the cmrSpacing classes since this is a much more elegant solution for adding the spacing 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Jskobos I wasn't able to reproduce the /preferences issue. I was having trouble with the mock service worker there, though... could that have been what you were experiencing?