M3-4717 Change: Hide empty notification sections in drawer#7191
Merged
Jskobos merged 2 commits intolinode:developfrom Dec 11, 2020
Jskobos:M3-4717-hide-empty-notification-sections
Merged
M3-4717 Change: Hide empty notification sections in drawer#7191Jskobos merged 2 commits intolinode:developfrom Jskobos:M3-4717-hide-empty-notification-sections
Jskobos merged 2 commits intolinode:developfrom
Jskobos:M3-4717-hide-empty-notification-sections
Conversation
- Change NotificationSection to return null if the passed list of notifications is empty - Add a message for section view saying "nothing to see here" if all sections are empty (chronological view already has this message)
Contributor
johnwcallahan
left a comment
johnwcallahan
left a comment
There was a problem hiding this comment.
We should probably retain a link to /events somehow.
Maybe: "No new notifications. View history."?
tiffwong
approved these changes
Dec 10, 2020
johnwcallahan
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
of notifications is empty
if all sections are empty (chronological view already has this message)