Hotfix: Make sure inline action isn't disabled#7309
Merged
Jskobos merged 1 commit intolinode:release-1.28.0from Jan 14, 2021
Jskobos:hotfix/reboot
Merged
Hotfix: Make sure inline action isn't disabled#7309Jskobos merged 1 commit intolinode:release-1.28.0from Jskobos:hotfix/reboot
Jskobos merged 1 commit intolinode:release-1.28.0from
Jskobos:hotfix/reboot
Conversation
Jskobos
changed the title
tiffwong
approved these changes
Jan 14, 2021
johnwcallahan
approved these changes
Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merging inline and normal actions led to the Reboot action breaking, since (for good reasons) we don't request a Linode's configs until someone opens the menu for that Linode.
I'd like to remove this whole configs check from the action menu. I've never been a fan, and there's a useful error if you try to reboot a Linode without configs from the API. Conversation for another day.