M3-6068: Incorrect tab selection on Linode Create#8717
Merged
CodyFinn-Akamai merged 3 commits intolinode:hotfix/jan-13-23-multiple-fixesfrom Jan 13, 2023
Merged
M3-6068: Incorrect tab selection on Linode Create#8717CodyFinn-Akamai merged 3 commits intolinode:hotfix/jan-13-23-multiple-fixesfrom
CodyFinn-Akamai merged 3 commits intolinode:hotfix/jan-13-23-multiple-fixesfrom
Conversation
cpathipa
changed the title
mjac0bs
previously approved these changes
Jan 12, 2023
Contributor
jcallahan-akamai
left a comment
jcallahan-akamai
left a comment
There was a problem hiding this comment.
This change should be made in SelectPlanQuantityPanel too, so that the change is reflected on the Create Kubernetes page as well. Otherwise LGTM.
Contributor
Author
Thank you @jcallahan-akamai for guiding on this, I wasn't aware of this screen. Updated
|
bnussman-akamai
previously approved these changes
Jan 13, 2023
dwiley-akamai
previously approved these changes
Jan 13, 2023
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Looks good 🚢
Let's point the base branch to staging instead of develop
CodyFinn-Akamai
dismissed stale reviews from dwiley-akamai, bnussman-akamai, and mjac0bs
The base branch was changed.
bnussman-akamai
force-pushed
the
M3-6068-bug-fix
branch
from
c264401 to
0f46209
Compare
cpathipa
changed the base branch from
develop
to
hotfix/jan-13-23-multiple-fixes
dwiley-akamai
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Sets plan tab to "Dedicated"
Preview 📷
Remove this section or include a screenshot or screen recording of the change
How to test 🧪
Navigate to create linode
Validate the plan tab is set to default if no plan is selected.