chore: [M3-6232] - Update VolumeStatus type and logic#8862
Conversation
bnussman-akamai
added
the
@linode/api-v4
| | 'resizing' | ||
| | 'deleting' | ||
| | 'deleted' | ||
| | 'migrating' |
There was a problem hiding this comment.
Are status of migrating and offline just not documented in the API docs? The only statuses I saw in the enum were creating, active, and resizing, though I may have missed something.
I was curious when a volume would return a status of migrating; I had tried to migrate a Linode with an attached volume, the message said
There was a problem hiding this comment.
You're right. The API docs are wrong here. I test against my local API to verify what the API may actually return.
The status of migrating is left over from the HDD to NVME migration but is still possible from a technical perspective
There was a problem hiding this comment.
Got it, thanks for clarifying!
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Unit tests looked good and so do the MSW updates. I called out one note about the StatusIcon, but it's a minor copy change suggestion and so I'm going to go ahead and approve.
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
LGTM 🚢
Can we give the Docs team a heads-up re: the accuracy of the status field enums?
4 participants
Description 📝
Preview 📷
How to test 🧪
yarn test volumeTurn on the MSW to see all of the possible volume statuses on
/volumes