refactor: [M3-6412, M3-6413, M3-6650] - MUI v5 - `Components > TagCell, Tags, AddTag` by hana-akamai · Pull Request #9186 · linode/manager

hana-akamai · 2023-05-26T20:36:50Z

Description 📝

Migrate styles for the TagCell and AddTag component
Update Tags component to match our current patterns

Preview 📷

How to test 🧪

Check tags around the app for regressions
Ensure the Tags story renders in Storybook

cypress · 2023-05-26T21:07:51Z

1 flaky tests on run #3953 ↗︎

0	167	3	0	1

Details:

Added changeset: MUI v5 Migration -
Project: Cloud Manager E2E	Commit: `42a70a4f58`
Status: Passed	Duration: 13:47 💡
Started: Jun 1, 2023 9:09 PM	Ended: Jun 1, 2023 9:23 PM

cypress/e2e/linodes/rescue-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Rescue Linodes > Cannot reboot a provisioning Linode into rescue mode		`Output` `Screenshots` `Video`

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

dwiley-akamai

Tags LGTM in the app. Left a comment re: additional file cleanup in the src/components/TagCell directory

packages/manager/src/components/TagCell/index.tsx

packages/manager/src/components/TagCell/TagCell.tsx

…sLanding (#9046) * Initial idea for RQ events Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Initial working version of useEventsPolling hook Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Re-implementation of useEventsPolling hook Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Completed initial implementation of useEvents hook Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Invalidate events cache when new events are fetched Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Use read instead of seen flag for polling Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Implement polling interval Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Switch to RQ hook for notifications menu Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Switch EventsLanding to RQ hook and enhance top-menu Fixes notification menu button background color disappearing on hover in dark mode Fix Notification menu doesn't close when navigating to EventsLanding Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Implement markEventsAsSeen mutation Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Temporarily re-enable redux polling Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Track previously existing in-progress events Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Remove old test Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Move NotificationMenu styled component to dedicated file * Follow style guide in EventsLanding * Rename TopMenuIconWrapper * fix: Re-add `fs` import to Cypress config (#9199) * add `fs` import * use cleaner import --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6382] - MUI v5 - `Components > Radio` (#9185) * move styles to theme and update stories * remove incorrect color --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6411] - MUI v5 - `Components > Tag` (#9164) ## Description 📝 Migrate styles for the Tag component ## How to test 🧪 Confirm that there have been no Tag regressions across the app Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * refactor: [M3-6412, M3-6413, M3-6650] - MUI v5 - `Components > TagCell, Tags, AddTag` (#9186) ## Description 📝 Migrate styles for the TagCell and AddTag component Update Tags component to match our current patterns ## How to test 🧪 - Check tags around the app for regressions - Ensure the Tags story renders in Storybook --------- Co-authored-by: Hussain Khalil <hussain@sanpilot.co> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>

@jaalah-akamai

* refactor: [M3-6570] - RQ-ify Events - Part 1: NotificationMenu, EventsLanding (#9046) * Initial idea for RQ events Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Initial working version of useEventsPolling hook Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Re-implementation of useEventsPolling hook Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Completed initial implementation of useEvents hook Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Invalidate events cache when new events are fetched Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Use read instead of seen flag for polling Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Implement polling interval Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Switch to RQ hook for notifications menu Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Switch EventsLanding to RQ hook and enhance top-menu Fixes notification menu button background color disappearing on hover in dark mode Fix Notification menu doesn't close when navigating to EventsLanding Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Implement markEventsAsSeen mutation Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Temporarily re-enable redux polling Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Track previously existing in-progress events Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Remove old test Co-authored-by: Hussain Khalil <hussain@sanpilot.co> * Move NotificationMenu styled component to dedicated file * Follow style guide in EventsLanding * Rename TopMenuIconWrapper * fix: Re-add `fs` import to Cypress config (#9199) * add `fs` import * use cleaner import --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6382] - MUI v5 - `Components > Radio` (#9185) * move styles to theme and update stories * remove incorrect color --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6411] - MUI v5 - `Components > Tag` (#9164) ## Description 📝 Migrate styles for the Tag component ## How to test 🧪 Confirm that there have been no Tag regressions across the app Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * refactor: [M3-6412, M3-6413, M3-6650] - MUI v5 - `Components > TagCell, Tags, AddTag` (#9186) ## Description 📝 Migrate styles for the TagCell and AddTag component Update Tags component to match our current patterns ## How to test 🧪 - Check tags around the app for regressions - Ensure the Tags story renders in Storybook --------- Co-authored-by: Hussain Khalil <hussain@sanpilot.co> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * Undo no-longer needed changes to top menu icons * refactor: [M3-6571] - RQ-ify Events - Part 2: Event Handlers (#9293) * Make polling part of EventsInfiniteQuery * Move event utilities to utilities folder * Create events query container * Migrate App events handlers to new events hook * Migrate toast notifications to new hook * Move app event handlers to hook * Finish migrating event handlers * Remove events redux store * Fix failing test * Fix issue causing multiple pages of events to refresh * implement page zero for new events * Optimize/reduce calls to events endpoint * Implement rolling-time polling * Fix events being duplicated * Fix unsupported API filter * Fix index out of bounds bug * Fix broken in-progress events polling * Get rid of separate page zero cache and store new events in first page instead * Undo accidental changes to cachedData * remove leftover pageZero stuff * Fix undefined recent event * Start from page 1 * Feedback @jaalah-akamai * New hook for synchronizing polling intervals * Remove unused exports * Custom implementation of partition util * Sort in-progress events to top * Use events instead of data * Use React.useMemo * Fix state accidental deletion * Clean up useToastNotifications * Add changesets * Remove Redux connector in EventsLanding * Rename to NotificationMenu.styles.ts * nodebalanacer -> nodebalancer * Import from src/components instead of MUI * Replace CombinedProps with EventsLandingProps --------- Co-authored-by: Hussain Khalil <hussain@sanpilot.co> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>

migrate TagCell styles

6713002

hana-akamai added Ready for Review Project: MUI v5 Migration labels May 26, 2023

hana-akamai self-assigned this May 26, 2023

update Tags component

40d1471

hana-akamai changed the title ~~refactor: [M3-6412] - MUI v5 - Components > TagCell~~ refactor: [M3-6412] - MUI v5 - Components > TagCell, Tags May 26, 2023

dwiley-akamai self-requested a review May 31, 2023 14:57

dwiley-akamai reviewed May 31, 2023

View reviewed changes

packages/manager/src/components/TagCell/index.tsx Outdated Show resolved Hide resolved

jaalah-akamai reviewed May 31, 2023

View reviewed changes

packages/manager/src/components/TagCell/TagCell.tsx Show resolved Hide resolved

jaalah-akamai approved these changes May 31, 2023

View reviewed changes

address feedback

bdcb0ea

hana-akamai added Work in Progress and removed Ready for Review labels May 31, 2023

hana-akamai added 2 commits June 1, 2023 14:58

migrate AddTag styles

8b3382d

Merge branch 'develop' into M3-6412-tag-cell

83924ec

hana-akamai changed the title ~~refactor: [M3-6412] - MUI v5 - Components > TagCell, Tags~~ refactor: [M3-6412, M3-6413, M3-6650] - MUI v5 - Components > TagCell, Tags, AddTag Jun 1, 2023

hana-akamai added Add'tl Approval Needed Waiting on another approval! and removed Work in Progress labels Jun 1, 2023

hana-akamai requested a review from dwiley-akamai June 1, 2023 19:01

Added changeset: MUI v5 Migration -

42a70a4

dwiley-akamai approved these changes Jun 2, 2023

View reviewed changes

hana-akamai merged commit 3bc1758 into linode:develop Jun 2, 2023

hana-akamai deleted the M3-6412-tag-cell branch June 2, 2023 15:15

jaalah-akamai mentioned this pull request Jun 9, 2023

Release v1.95.0 - release → staging #9236

Merged

dwiley-akamai mentioned this pull request Jun 12, 2023

Release v1.95.0 – staging → master #9250

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: [M3-6412, M3-6413, M3-6650] - MUI v5 - `Components > TagCell, Tags, AddTag`#9186

refactor: [M3-6412, M3-6413, M3-6650] - MUI v5 - `Components > TagCell, Tags, AddTag`#9186
hana-akamai merged 6 commits intolinode:developfrom
hana-akamai:M3-6412-tag-cell

hana-akamai commented May 26, 2023 •

edited

Loading

Uh oh!

cypress bot commented May 26, 2023 •

edited

Loading

Uh oh!

dwiley-akamai left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hana-akamai commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Preview 📷

How to test 🧪

Uh oh!

cypress bot commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 flaky tests on run #3953 ↗︎

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hana-akamai commented May 26, 2023 •

edited

Loading

cypress bot commented May 26, 2023 •

edited

Loading