Skip to content

fix: Fix Linode landing page delete smoke test flake #9348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdamore-linode merged 3 commits into from
Jul 3, 2023
Merged

fix: Fix Linode landing page delete smoke test flake #9348

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d91dfca
Wait for landing page to update before deleting next Linode
Jun 29, 2023
c9765c1
Use Linode API SDK to create Linodes for test
Jun 29, 2023
e581537
Remove '.only'
Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 34 additions & 17 deletions packages/manager/cypress/e2e/core/linodes/smoke-linode-landing-table.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
/* eslint-disable sonarjs/no-duplicate-string */
import { createLinode } from '@linode/api-v4';
import { Linode } from '@linode/api-v4/types';
import { createLinode } from 'support/api/linodes';
import { accountSettingsFactory } from '@src/factories/accountSettings';
import {
createLinodeRequestFactory,
linodeFactory,
} from '@src/factories/linodes';
import { makeResourcePage } from '@src/mocks/serverHandlers';
import {
containsVisible,
fbtVisible,
getClick,
getVisible,
} from 'support/helpers';
import { linodeFactory } from '@src/factories/linodes';
import { makeResourcePage } from '@src/mocks/serverHandlers';
import { accountSettingsFactory } from '@src/factories/accountSettings';
import { routes } from 'support/ui/constants';
import { ui } from 'support/ui';
import { routes } from 'support/ui/constants';
import { apiMatcher } from 'support/util/intercepts';
import { randomLabel } from 'support/util/random';
import { chooseRegion, getRegionById } from 'support/util/regions';
import { authenticate } from 'support/api/authentication';

const mockLinodes = new Array(5).fill(null).map(
(_item: null, index: number): Linode => {
Expand Down Expand Up @@ -56,7 +61,9 @@ const deleteLinodeFromActionMenu = (linodeLabel) => {
.should('be.enabled')
.click();
});

cy.wait('@deleteLinode').its('response.statusCode').should('eq', 200);
cy.findByText(linodeLabel).should('not.exist');
};

const preferenceOverrides = {
Expand All @@ -70,6 +77,7 @@ const preferenceOverrides = {
},
};

authenticate();
describe('linode landing checks', () => {
beforeEach(() => {
const mockAccountSettings = accountSettingsFactory.build({
Expand Down Expand Up @@ -292,23 +300,32 @@ describe('linode landing actions', () => {
managed: false,
});

const createTwoLinodes = async (): Promise<[Linode, Linode]> => {
return Promise.all([
createLinode(
createLinodeRequestFactory.build({ label: randomLabel() })
),
createLinode(
createLinodeRequestFactory.build({ label: randomLabel() })
),
]);
};

cy.intercept('GET', apiMatcher('account/settings'), (req) => {
req.reply(mockAccountSettings);
}).as('getAccountSettings');

cy.intercept('DELETE', apiMatcher('linode/instances/*')).as('deleteLinode');
createLinode().then((linodeA) => {
createLinode().then((linodeB) => {
cy.visitWithLogin('/linodes', { preferenceOverrides });
cy.wait('@getAccountSettings');
getVisible('[data-qa-header="Linodes"]');
if (!cy.get('[data-qa-sort-label="asc"]')) {
getClick('[aria-label="Sort by label"]');
}
deleteLinodeFromActionMenu(linodeA.label);
deleteLinodeFromActionMenu(linodeB.label);
cy.findByText('Oh Snap!', { timeout: 1000 }).should('not.exist');
});
cy.defer(createTwoLinodes()).then(([linodeA, linodeB]) => {
cy.visitWithLogin('/linodes', { preferenceOverrides });
cy.wait('@getAccountSettings');
getVisible('[data-qa-header="Linodes"]');
if (!cy.get('[data-qa-sort-label="asc"]')) {
getClick('[aria-label="Sort by label"]');
}
deleteLinodeFromActionMenu(linodeA.label);
deleteLinodeFromActionMenu(linodeB.label);
cy.findByText('Oh Snap!', { timeout: 1000 }).should('not.exist');
});
});
});