feat: Add support for self serve betas endpoints#9386
Merged
CodyFinn-Akamai merged 10 commits intolinode:developfrom Jul 20, 2023
Merged
feat: Add support for self serve betas endpoints#9386CodyFinn-Akamai merged 10 commits intolinode:developfrom
CodyFinn-Akamai merged 10 commits intolinode:developfrom
Conversation
bnussman-akamai
added
@linode/api-v4
1 flaky tests on run #4873 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| object storage failure paths > shows error upon object upload failure |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Contributor
|
@CodyFinn-Akamai looks good! Just run |
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Looks good overall, made some comments for cleanup and to bring things in line with our current RQ patterns
Adds support for the self serve beta endpoints by: * Adding endpoint wrapper functions in api-v4 package * Adding factories for betas and account betas * Adding server handlers for betas and account betas endpoints * Adding queries for betas and account betas
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
CodyFinn-Akamai
force-pushed
the
self-serve-beta-api
branch
from
7650e1c to
608a0ac
Compare
Contributor
|
@CodyFinn-Akamai this is looking good, there's a few pending comments from @dwiley-akamai remaining, otherwise GTG! |
jaalah-akamai
approved these changes
Jul 18, 2023
bnussman-akamai
added
Add'tl Approval Needed
dwiley-akamai
approved these changes
Jul 18, 2023
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Left two other minor comments but this is good to go aside from those
bnussman-akamai
added
Approved
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
harshithasarva-akamai
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds support for the self serve beta endpoints by:
Major Changes 🔄
List highlighting major changes
How to test 🧪