feat: [M3-6966] - Add DC-specific pricing to Linode Create flows#9598
feat: [M3-6966] - Add DC-specific pricing to Linode Create flows#9598abailly-akamai merged 17 commits intolinode:developfrom
Conversation
abailly-akamai
force-pushed
the
feat-M3-6967
branch
2 times, most recently
from
190bbb4 to
9c45a37
Compare
There was a problem hiding this comment.
Decided to use a notice on Mobile so it stands out a little better than plain text (since it is not in a table) - open to suggestions
There was a problem hiding this comment.
My suggestion here would be to make this an info variant of the notice, rather than a warning. I think this is more in line with the Region pricing notice above. Can we do a quick check in with UX?
There was a problem hiding this comment.
I agree with making this the info variant.
There was a problem hiding this comment.
Yup! will update. UX approved it as the info variant as well
There was a problem hiding this comment.
Followed suit in the kube plans table, too. 👍🏼
There was a problem hiding this comment.
Moved to the pricing backup utils tests
There was a problem hiding this comment.
Moved to the pricing backup utils
There was a problem hiding this comment.
@mjac0bs to confirm this is where we want it
mjac0bs
changed the title
abailly-akamai
force-pushed
the
feat-M3-6967
branch
from
34a11e6 to
7d342d8
Compare
packages/manager/src/features/components/PlansPanel/PlanContainer.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/components/PlansPanel/PlanSelection.tsx
Outdated
Show resolved
Hide resolved
abailly-akamai
force-pushed
the
feat-M3-6967
branch
from
7d342d8 to
2214b23
Compare
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Very nice! Found no issues 🚀
bnussman-akamai
added
Add'tl Approval Needed
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks for this work! This is looking good throughout the create flows, checked create from backup and clone, in particular. Confirmed the smaller screens have the notice and the selection cards correctly update based on dynamic pricing in subheaders.
It doesn't look like the code has been pushed yet to change to info, so approving pending that and I know you're working on tests.
abailly-akamai
force-pushed
the
feat-M3-6967
branch
from
1ecf9f4 to
01ac61f
Compare
* feat: [M3-6966] Initial commit: selection panels * feat: [M3-6966] Linode: Checkout summary * feat: [M3-6966] Fix display conditional * Added changeset: Add DC specific Linode Create pricing support * feat: [M3-6967] add comment * feat: [M3-6967] reset flag state on component update * feat: [M3-6967] consolidate tests and utils * feat: [M3-6967] cleanup * feat: [M3-6967] moar cleanup and comments * feat: [M3-6967] quick display fix * feat: [M3-6967] fix for DB create flow * feat: [M3-6967] address feedback * feat: [M3-6967] add tests * feat: [M3-6967] cleanup tests * feat: [M3-6967] cleanup tests * feat: [M3-6967] address feedback (notice) * feat: [M3-6967] small fix to flag prop and cleanup
3 participants
Description 📝
Adds dynamic pricing to Linode Create flows (⚠️ NOT k8 clusters which will be done in another ticket)
Preview 📷
How to test 🧪