feat: [M3-7048] - Add DC-specific pricing for Kubernetes node pools by mjac0bs · Pull Request #9606 · linode/manager

mjac0bs · 2023-08-30T13:59:09Z

Description 📝

This PR adds DC-specific pricing for Kubernetes node pools in the create flow and on the details page in add/resize drawers.

Major Changes 🔄

With the mocks and feature flag on:
Kube Create page:

When a region is selected, the Node Pools table displays the hourly and monthly pricing corresponding to the selected region.
When a region is not selected, the Node Pools table does not display rows, and instead displays a message: "Select a Region to view plans and prices."
The Cluster Summary displays correctly calculated DC-specific pricing based on the Linode's region – both Node Pool line items and the total.
When either a region or a pool is not selected, the cluster summary does not display prices and displays helper text indicating what selections must be made for pricing and cluster creation.

Kube Details page:

Kube cluster specs displays a correctly calculated total DC-specific total price of the cluster/month.

Add a Node Pool drawer:

The Node Pools table displays the hourly and monthly pricing corresponding to the region the cluster is in.
The drawer copy displays correctly calculated DC-specific pricing based on the cluster's region.

Resize Pool drawer:

The drawer copy displays correctly calculated DC-specific pricing based on the cluster's region.

Preview 📷

Flow/Component	Before	After
Create Cluster -> Node Pool Panel & Plan Selection
Create Cluster -> Checkout Bar
Kubenetes Cluster Details -> Specs
Kubernetes Cluster Details -> Add Node Pool Drawer
Kubernetes Cluster Details -> Resize Node Pool Drawer

How to test 🧪

How to setup test environment?

Ensure DC-Specific Pricing flag and MSW are both on.
To test, I temporarily modified the kubernetesAPIResponse and kubernetesClusterFactory factories and replaces region: 'us-central' with region: 'id-cgk'.

How to verify changes?

Test that the above changes are visible with the DC-Specific Pricing flag on and not visible with the flag off.
Confirm that the plans selection cards in mobile view update dynamically with region selection when the flag is on and the notice looks good.

How to run Unit or E2E tests?

yarn test NodePoolPanel kubeUtils ResizeNodePoolDrawer KubeCheckoutBar KubernetesPlanContainer KubernetesPlanSelection

I did not cover the Add/Resize Node Pool drawers. There is an lke-update.spec.ts testing adding and resizing node pools; these should be updated in an e2e ticket.

abailly-akamai

Looks great, no defect found. nice work! 🚀

just a few nice to have or follow ups

abailly-akamai · 2023-09-01T13:50:21Z

packages/manager/src/features/Kubernetes/KubeCheckoutBar/KubeCheckoutBar.tsx

Note for later: not a blocker but we may want to revisit not rendering anything (and just an error) if missing types?

abailly-akamai · 2023-09-01T13:51:46Z

packages/manager/src/features/Kubernetes/KubeCheckoutBar/KubeCheckoutBar.tsx

Would be nice to rename this util getKubeMonthlyPrice and move it to the pricing utils for consistency

abailly-akamai · 2023-09-01T13:52:54Z

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx

We should type highAvailabilityPrice as PriceObject for consistency.

abailly-akamai · 2023-09-01T13:53:58Z

...nager/src/features/Kubernetes/KubernetesClusterDetail/NodePoolsDisplay/AddNodePoolDrawer.tsx

same for those, types are inferred but i think we should be more strict

abailly-akamai · 2023-09-01T13:54:27Z

...er/src/features/Kubernetes/KubernetesClusterDetail/NodePoolsDisplay/ResizeNodePoolDrawer.tsx

abailly-akamai · 2023-09-01T13:55:54Z

packages/manager/src/features/Kubernetes/KubernetesPlansPanel/KubernetesPlanContainer.tsx

😃 ty (i've seen this somewhere else ;) !

abailly-akamai · 2023-09-01T13:56:30Z

packages/manager/src/features/Kubernetes/KubernetesPlansPanel/KubernetesPlanSelection.test.tsx

fantastic! 🎉

abailly-akamai · 2023-09-01T14:06:26Z

@jdamore-linode since we may merge this PR while @mjac0bs is away, do you mind checking if the failing object-storage.e2e test is relevant? I ran things locally without a problem but would be nice to be confident

bnussman-akamai

All flows showed correct prices! 💵

jdamore-linode · 2023-09-01T19:19:45Z

@jdamore-linode since we may merge this PR while @mjac0bs is away, do you mind checking if the failing object-storage.e2e test is relevant? I ran things locally without a problem but would be nice to be confident

@abailly-akamai We can disregard the failure! We were having an OBJ incident earlier today around the time of this run that I think is responsible for the failure; it just passed locally for me 👍

…9606) * Update kube utils for dynamic pricing * Add DC-specific dynamic pricing for Add and Resize Node Pool drawers * Add DC-specific dynamic pricing to cluster specs and checkout bar * Update test * Add DC-specific dynamic pricing in kube node pools tables * Display dynamic prices in the selection card, mobile view * Render mobile view empty state plan table helper text in Notice * WIP: suspicious tests * Update unit tests * Cleanup * Added changeset: Add DC-specific pricing to Kubernetes node pools * feat: [M3-7048] feedback --------- Co-authored-by: Alban Bailly <abailly@akamai.com>

mjac0bs added the DC-Specific Pricing label Aug 30, 2023

mjac0bs self-assigned this Aug 30, 2023

mjac0bs force-pushed the M3-7048-add-dc-pricing-for-kube-node-pools branch 3 times, most recently from 4661995 to 456bb81 Compare September 1, 2023 05:56

mjac0bs marked this pull request as ready for review September 1, 2023 06:04

bnussman-akamai added Ready for Review Missing Changeset and removed Missing Changeset labels Sep 1, 2023

mjac0bs requested review from abailly-akamai and bnussman-akamai September 1, 2023 06:26

abailly-akamai approved these changes Sep 1, 2023

View reviewed changes

bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Sep 1, 2023

bnussman-akamai approved these changes Sep 1, 2023

View reviewed changes

bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 1, 2023

mjac0bs added 9 commits September 1, 2023 16:24

Update kube utils for dynamic pricing

d272da2

Add DC-specific dynamic pricing for Add and Resize Node Pool drawers

fd3676e

Add DC-specific dynamic pricing to cluster specs and checkout bar

7460a6e

Update test

792adf7

Add DC-specific dynamic pricing in kube node pools tables

22ad271

Display dynamic prices in the selection card, mobile view

dd2f1b9

Render mobile view empty state plan table helper text in Notice

b8dfab2

WIP: suspicious tests

864daaa

Update unit tests

fae6bf4

mjac0bs and others added 3 commits September 1, 2023 16:24

Cleanup

9077355

Added changeset: Add DC-specific pricing to Kubernetes node pools

e56a33a

feat: [M3-7048] feedback

d7055c0

abailly-akamai force-pushed the M3-7048-add-dc-pricing-for-kube-node-pools branch from ed7e79c to d7055c0 Compare September 1, 2023 20:25

abailly-akamai merged commit 8fc7ce9 into linode:develop Sep 2, 2023

This was referenced Sep 15, 2023

Release v1.102.0 - release → staging #9686

Merged

Release v1.102.0 - staging → master #9695

Merged

mjac0bs mentioned this pull request Oct 12, 2023

feat: [M3-7063] - Provide dynamic price error handling for DC-specific pricing #9660

Merged

20 tasks

mjac0bs mentioned this pull request Nov 9, 2023

change, test: [M3-7073, M3-7176] - Remove dcSpecificPricing and objDcSpecificPricing feature flags #9881

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7048] - Add DC-specific pricing for Kubernetes node pools#9606

feat: [M3-7048] - Add DC-specific pricing for Kubernetes node pools#9606
abailly-akamai merged 12 commits intolinode:developfrom
mjac0bs:M3-7048-add-dc-pricing-for-kube-node-pools

mjac0bs commented Aug 30, 2023 •

edited

Loading

Uh oh!

abailly-akamai left a comment •

edited

Loading

Uh oh!

abailly-akamai Sep 1, 2023

Uh oh!

abailly-akamai Sep 1, 2023

Uh oh!

abailly-akamai Sep 1, 2023

Uh oh!

abailly-akamai Sep 1, 2023

Uh oh!

abailly-akamai Sep 1, 2023

Uh oh!

abailly-akamai Sep 1, 2023

Uh oh!

abailly-akamai Sep 1, 2023

Uh oh!

abailly-akamai commented Sep 1, 2023

Uh oh!

bnussman-akamai left a comment

Uh oh!

jdamore-linode commented Sep 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mjac0bs commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Major Changes 🔄

Preview 📷

How to test 🧪

Uh oh!

abailly-akamai left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Sep 1, 2023

Choose a reason for hiding this comment

Uh oh!

abailly-akamai commented Sep 1, 2023

Uh oh!

bnussman-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

jdamore-linode commented Sep 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mjac0bs commented Aug 30, 2023 •

edited

Loading

abailly-akamai left a comment •

edited

Loading