feat: [UIE-6576] - Dbaas total disk size and used disk size#9638
Conversation
70518ef to
e1b1a53
Compare
abailly-akamai
left a comment
There was a problem hiding this comment.
Thanks for submitting! left a few comments
...rc/features/Databases/DatabaseDetail/DatabaseSummary/DatabaseSummaryClusterConfiguration.tsx
Outdated
Show resolved
Hide resolved
| <Typography className={classes.label}>Storage</Typography> | ||
| {convertMegabytesTo(type.disk, true)} | ||
| </Box> | ||
| {database.total_disk_size_gb ? ( |
There was a problem hiding this comment.
Don't we want to make a new feature flag and use it as an additional conditional here? This works but wondering if the scope may expand?
There was a problem hiding this comment.
The backend has a feature gate for the rollout. I asked about a UI flag, but they said the backend API response should suffice.
There was a problem hiding this comment.
gotcha, thx for the explanation
bnussman-akamai
left a comment
There was a problem hiding this comment.
Looks good in alpha! 🎉
I'd like to know why this is feature flagged on the API side. Do we expect this feature to ever be turned off? Should we add our own feature flag on the frontend for this?
The backend added a feature flag for the rollout. It's turned off initially to verify no regressions were introduced. When I asked about adding a flag on the UI, they said the API response can drive the behavior. |
|
Ran e2es locally and everything passed ✅ |
Description 📝
Adding two new fields to display (1) the total disk size available for the database (Selected size - OS overhead) and (2) the used disk space so the customer will now how much space is remaining in the DB. BE will be feature gated, so UI will fallback to current storage field if the API response does not contain the total_disk_space
Major Changes 🔄
Preview 📷
How to test 🧪