feat: [M3-6993] – Add VPC data to Linode Detail header#9645
Merged
dwiley-akamai merged 11 commits intolinode:developfrom Sep 15, 2023
Merged
feat: [M3-6993] – Add VPC data to Linode Detail header#9645dwiley-akamai merged 11 commits intolinode:developfrom
dwiley-akamai merged 11 commits intolinode:developfrom
Conversation
packages/manager/src/features/Linodes/LinodeEntityDetail.styles.ts
Outdated
Show resolved
Hide resolved
dwiley-akamai
commented
Sep 11, 2023
| }); | ||
|
|
||
| const { data: configs } = useAllLinodeConfigsQuery(linodeId); | ||
| let _configInterfaceWithVPC: Interface | undefined; |
Contributor
Author
There was a problem hiding this comment.
Opted for this approach to hold the interface data as opposed to looping through two separate times as in the initial commit
hana-akamai
reviewed
Sep 13, 2023
Contributor
hana-akamai
left a comment
hana-akamai
left a comment
There was a problem hiding this comment.
Looks like there's a bit of border missing on the right side
Contributor
Author
I haven't been able to get the border to extend all the way -- when I inspect that VPC subpanel, Dev Tools indicates there's a negative margin (❓):
@jaalah-akamai any insights into how to fix this issue? |
Contributor
|
I had to abort the e2e test run because one of the runners was hanging, but all of the tests did run and pass -- feel free to treat it as a pass 👍 (cc @dwiley-akamai @jaalah-akamai ) |
jaalah-akamai
approved these changes
Sep 14, 2023
hana-akamai
approved these changes
Sep 14, 2023
This was referenced Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
For Linodes assigned to a VPC, display the linkified VPC label, the subnets list, and the VPC IPv4 address in a "VPC" section in the Linode Detail header.
To-Do:
Major Changes 🔄
For Linodes assigned to a VPC, display a "VPC" section in the Linode Detail header.
Also, add an
enabledargument to theuseVPCsQuery()so that the query doesn't run on Linode Detail pages if the VPC section shouldn't be displayed.Preview 📷
How to test 🧪
Confirm that a Linode assigned to a VPC has the VPC section added to its Detail header.
Confirm that a Linode not assigned to a VPC does not have the VPC section in its Detail header.