feat: [M3-6747] - Add filter subnets field#9647
Merged
hana-akamai merged 5 commits intolinode:developfrom Sep 8, 2023
Merged
Conversation
abailly-akamai
approved these changes
Sep 8, 2023
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Works as expected 👍
We eventually may want to abstract < DebouncedSearchTextField /> and make a new component or similar since it's reused in all new designs including AGLB. Would improve reusability and make sure we are consistent with styling and debounce times
packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.tsx
Outdated
Show resolved
Hide resolved
This was referenced Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Screen.Recording.2023-09-07.at.4.28.47.PM.mov
How to test 🧪
Create some subnets in a VPC and try to filter by label/id. Ensure that table column sorting still works.