feat: [M3-7096] - Show Region label in addition to id on Invoices#9663
Conversation
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks for the updates with some good clean up and tests! 🧹 Left a couple tiny suggestions.
Also: can we update the MSW invoice items endpoint (rest.get('*invoices/555/items',) so we're seeing an accurate representation of what an overage line item in the global transfer pool?
It looks like that includes the substring "Transfer Overage" and we've currently got "Outbound Transfer".
packages/manager/src/features/Billing/PdfGenerator/utils.test.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Billing/PdfGenerator/utils.test.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Billing/InvoiceDetail/InvoiceTable.tsx
Outdated
Show resolved
Hide resolved
| <TableCell colSpan={columns}> | ||
| <TableCell | ||
| colSpan={columns} | ||
| sx={{ paddingLeft: '0px !important' }} |
There was a problem hiding this comment.
What was the crazy styling issue here?
There was a problem hiding this comment.
The pagination controls are inside of a table row for some reason, causing weird padding and a weird hover state. I just did this as a simple fix for now. You can see the bug in production.
There was a problem hiding this comment.
Oh, that is weird. In a table row for alignment purposes, I guess? Layout gets weird when the table cell is removed. Since this is a temp fix and we're trying to avoid !important it would be great if we can get a ticket in the backlog just to document it.
There was a problem hiding this comment.
Would be nice to have tests for the PDF generation too. Could be a follow up but it wouldn't be too labor intensive using pdf-parse - will make a ticket
5 participants
Description 📝
labelandidin the DC specific pricing invoices. This ticket is a follow up to address some feedback from feat: [M3-6980] - Add DC Specific Pricing Invoice Support #9597.Preview 📷
Important
The CSV does not contain the region
labelbecause I followed the current pattern of showing "pure" API data. (Notice how the dates are in the API's format)How to test 🧪
labels andids on the Invoices with theDC Specific Pricingfeature flag on