feat: [M3-7033] - Update Firewall Landing Device Column by tyler-akamai · Pull Request #9668 · linode/manager

tyler-akamai · 2023-09-13T13:46:50Z

Description 📝

Updated Firewall Landing Device Column

Major Changes 🔄

Changes name of column from 'Linodes' to 'Devices'
Populated the 'Devices' column with devices instead of linodes
Increased the number of visible devices in the column from 3 to 8. Further work/discussion is needed later. The original ticket has it spanning 3 rows but the logic turned out more difficult than expected.

Preview 📷

Before	After

How to test 🧪

Navigate to http://localhost:3000/firewalls
Ensure the column header is 'Devices' instead of 'Linodes'
Ensure additional nodes past the third row are not shown.
Ensure the links still bring you to the device landing pages

… into M3-7033-Update-Firewall-Landing-Device-Column

…wall-Landing-Device-Column

coliu-akamai

Functionality works as expected! Had a couple questions/comments below.

It feels like the devices content list might be a bit cramped at the top/bottom, especially as the row has to grow to fit all 8 devices and if the device names are super long (like my randomly generated 63 char device names haha) -- might be worth adding some padding on the top and bottom? For example:

packages/manager/src/features/Firewalls/FirewallLanding/FirewallRow.tsx

coliu-akamai · 2023-09-13T14:47:18Z

Also, here's an image of what the page might potentially look like with multiple firewalls that have a lot of devices with super long names:

Padding might be helpful to differentiate between rows / help declutter a bit? Maybe check with UX! 👀 😄

coliu-akamai

Works/looks as expected, good work! Also don't forget to update the description of this PR / how to test this, now that the behavior is different

🎉

jaalah-akamai · 2023-09-13T20:50:53Z

Nice changes. Confirming everything looks good and that we walked through things together 🚀

* feat: [M3 7015] - Create nodebalancer tab in firewalls landing (#9590) * initial changes * finished the firewall device landing updates * Added changeset: Create nodebalancer tab in firewalls landing * fixed breadcrumb and variable names * added FirewallDeviceLanding test file * added initial unit tests * updated jest.mock function, still not working * swapped from jest.mock to MSW, still need some work * fixed unit tests * fixed tests for FirewallDeviceLanding --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * feat: [M3-7019] - Create add Nodebalancer to Firewall drawer (#9608) * initial drawer commit * finished the add nodebalancer drawer * Added changeset: Created 'Add Nodebalancer' to Firewall drawer * updated drawer and started to add event handlers * added toast notification * added multiple toast notifications * separated nodebalancer and linode drawer * added infinite scrolling * fixed pr suggestions * partially eliminated type definitions in LinodeSelect * eliminated type definitions in LinodeSelect * changed type definition of onSelectionChange in NodeBalancerSelect * eliminated type declarations in NodeBalancerSelect * erased commented out code * initial round of fixes * fixed linode error drawer not closing * eliminated event message * added todo comment * added todo comment * fixed toast notification, error reset, and error text * fixed toast notification, error reset, and error text for Linode Drawer * fixed nodebalancer drawer error notices * merged with develop * initial migration to new autocomplete component, still some errors * can select linodes now, but the linodes arent showing as selected * fixed selection issue with autocomplete * migrated to new autocomplete component * remove NodeBalancerSelect file changes * added banks PR suggestions --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * feat: [M3-7052] - Add NodeBalancer table under Firewall / Devices (#9664) * initial nodebalancer table commit * Added changeset: Added NodeBalancer table under Firewall/Devices * removed unnecessary prop extension --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * feat: [M3-7016] - Add Basic Filtering for Firewall Devices (#9626) * initial firewall device filter commit * Added changeset: Added Basic Filtering for Firewall Devices * cleaned up label content in TextField * initial ActionsPanel Storybook commit * reverted ActionsPanel changes * updated storybook * Fixed storybook * test commit - eslint issues * test commit * fixed text field * removed unnecessary code * added Alban's changes * test commit * removed test comment * fixed filtering error --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> Co-authored-by: Hana Xu <hxu@akamai.com> * feat: [M3-7033] - Update Firewall Landing Device Column (#9668) * initial update to device cell wrap functionality * added extra console line for width * still not working * updated the code, still not working * changes linodes column to devices column * fixed styling file * Added changeset: Updated Firewall Landing Device Column * removed unnecessary styling * fixed test results * added Connie's pr suggestions * updated styled row file * added line clamp to styled component * removed old test case * updated row spacing * fixed spacing --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * feat: [M3-7017] - Update firewall events (#9693) * feat: [M3-7017] - Update firewall events * Fix e2e test and secondary entity formatting * Add changeset * feat: [M3-7020] - Update Create Firewall drawer (#9630) * feat: [M3-7020] - Update Create Firewall drawer * Update firewall e2e tests for NodeBalancer UI improvements * Integrate new Autocomplete component * Change test description * Add UI indicator for errors and reset nb values * Add changeset * Move static strings outside component * Implement PR feedback suggestions * Remove unnecessary check and change var name --------- Co-authored-by: Joe D'Amore <jdamore@linode.com> * feat: [M3-7021] - Added Firewall panel to create NodeBalancer flow (#9733) * merged with upstream * Added changeset: Added Firewall Panel to NodeBalancer Create flow --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * fix: [M3-7245] - Replaced 'Devices' with 'Services' in Firewall Page (#9775) * replaced visible devices with services * fixed routing for drawers * Added changeset: Swapped 'Devices' to 'Services' in Firewall and updated Add Service to Firewall routing * updated unit tests, still need work * updated unit tests * updated capitalization and unit tests --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * fixed merge conflict * fix: [M3-7313] - Migrated Linode dropdown to Autocomplete in Firewall Landing > Create Firewall drawer (#9837) * migrated Linode dropdown to Autocomplete, fixed NodeBalancer dropdown, added successfull toast notification * Added changeset: Linode dropdown in Create Firewall drawer using LinodeSelect component instead of the Autocomplete component * fixed changeset message from last pr * updated unit tests * addressed Hana's feedback * removed helper text * initial changes to unnecessary state * addresses Banks feedback * addressed additional feedback * fixed syntax of optionsFilter * switched set to list for autocomplete --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * feat: [M3-7163] - Add Firewall Section to NodeBalancer Details Page (#9831) * first commit * Code cleanup * Fix quick bug * PR feedback changes * RQ changes * fixed toast notification errors * fixed toast notifications * PR feedback --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> * refactor: [M3-7377] - Migrate dopdowns in Create Firewall Drawer from Autocomplete to LinodeSelect and NodeBalancerSelect (#9886) * initial commit * updated font bold to use mui theme * migrated autocomplete to nodebalancer select * small naming changes * Updated CreateFirewallDrawer and SelectFirewallPanel * removed comments * Added changeset: Dropdowns in Create Firewall Drawer using Autocomplete instead of updated LinodeSelect and NodeBalancerSelect * fixed LinodeSelect unit tests * added NodeBalancer unit tests * fixed SelectFirewallPanel unit tests * added pr feedback * updated dropdown labels * fixed unit tests * fixed unit tests * fixed unit tests * working to fix timeout error * rerunning unit tests * test debug * merged with develop * testing unit tests * testing last unit test * testing last unit test * removed line to see if unit tests will pass * Replace calls to `jest.fn()` with `vi.fn()` * rerunning tests * fixed e2e tests * resolved pr suggestions --------- Co-authored-by: TylerWJ <tylerwjones99@gmail.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Joe D'Amore <jdamore@linode.com> * feature: [M3-7442] - Put Firewall-Nodebalancer behind feature flag (#9931) * initial feature flag migration * Added remaining code under feature flag * updated text in drawer * Added changeset: Added feature flag to Firewall-NodeBalancer * fixed unit test * fixed unit tests * added feature flag to dev tools * test commit * test commit * fixed border issue in firewall's table * partially fixed border issue * partially fixed border issue * fixed border issue * feat: [M3-7018] - Add documentation links for Firewall NodeBalancer (#9926) * added links * fixed nodebalancer create flow text * made link format more consistent * added changeset * fixed filter issue * removed comment * started to address Alban's feedback * fixed other instance of unnecessary else * addressed feedback for Firewall Drawer Props * added clamp-js for firewall landing * added clamp-js library * addressed some comments * addressed onService required prop feedback * addressed test feedbacl for FirewallDeviceLanding * addressed test feedback for FirewallDeviceLanding * added a todo in FirewallRulesLanding * added unit tests for addNodebalancerDrawer and addLinodeDrawer * addressed Connie's feedback ab aria labels * sanitized error messages in add drawers * added interface for secondaryEntityTypeObj * fixed link in create NodeBalancer flow * fixed header in create drawer * Update packages/manager/.changeset/pr-9926-upcoming-features-1700672014523.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * added period after Learn more in create firewall drawer * fixed nodebalancer create flow issue * NodeBalancer is now assigned to Firewall * removed unnecessary invalidate query * added doc link to NodeBalancer's details page * improved organization of the AddLinodeDrawer and AddNodeBalancerDrawer * added a constants file in FirewallLanding directory * Update packages/manager/.changeset/pr-9926-upcoming-features-1700672014523.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/.changeset/pr-9931-upcoming-features-1700686098973.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/FirewallDeviceTable.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/FirewallDeviceTable.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddNodebalancerDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddNodebalancerDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddNodebalancerDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/NodeBalancers/NodeBalancerDetail/NodeBalancerFirewalls.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/api-v4/src/nodebalancers/nodebalancers.ts Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/NodeBalancers/NodeBalancerDetail/NodeBalancerFirewalls.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddLinodeDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddNodebalancerDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddLinodeDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddLinodeDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Update packages/manager/src/features/Firewalls/FirewallDetail/Devices/AddLinodeDrawer.test.tsx Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * fixed import error * mapIdsToLinodes to mapIdsToDevices * fixed Linodes Network tab Firewall Table error state * fixed Linodes Network tab Firewall Table error state * fixed Create NodeBalancer add firewall flow * removed firewall_id forom NodeBalancerConfigNode * added firewall_id to the payload * fixed spelling issue * Fix darkmode link color discrepancy * added tags to CreateNodeBalancerPayload * Replace html anchor tag with Link component * change: [M3-7546] - Revert FW table row changes (#9974) * change: [M3-7546] - Revert NB table row changes * Fix linking for NodeBalancers from the table cell * Remove the `clamp-js` package * Add changeset * added links to constants file * changed SecondaryEntityType from interface to type * changed improved mapIdsToDevices tests to cover nodebalancers * Update packages/manager/src/features/Events/eventMessageGenerator.ts Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> * eliminated ternary in Summary Panel * cleaned up NodeBalancerSettings displayFirewallInfotext * Fix dark mode color issue on NB settings page * invalidated device queries after firewall has been deleted --------- Co-authored-by: tyler-akamai <139489745+tyler-akamai@users.noreply.github.com> Co-authored-by: TylerWJ <tylerwjones99@gmail.com> Co-authored-by: Hana Xu <hxu@akamai.com> Co-authored-by: Joe D'Amore <jdamore@linode.com> Co-authored-by: Tyler Jones <tjones@akamai.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

TylerWJ added 8 commits September 12, 2023 11:20

initial update to device cell wrap functionality

8986c1f

added extra console line for width

1cb7e83

Merge remote-tracking branch 'upstream/feature/firewall-nodebalancer'…

5eda5cc

… into M3-7033-Update-Firewall-Landing-Device-Column

still not working

7382dfa

updated the code, still not working

80d9702

Merge branch 'feature/firewall-nodebalancer' into M3-7033-Update-Fire…

8fd17b4

…wall-Landing-Device-Column

changes linodes column to devices column

f40fdb1

fixed styling file

8d5ed9a

tyler-akamai changed the title ~~M3 7033 update firewall landing device column~~ feat: [M3-7033] - Update Firewall Landing Device Column Sep 13, 2023

tyler-akamai self-assigned this Sep 13, 2023

tyler-akamai added the Nodebalancer Firewall UX label Sep 13, 2023

TylerWJ added 2 commits September 13, 2023 09:50

Added changeset: Updated Firewall Landing Device Column

929a868

removed unnecessary styling

54cc80f

tyler-akamai marked this pull request as ready for review September 13, 2023 14:10

tyler-akamai added the Ready for Review label Sep 13, 2023

fixed test results

391c8a7

coliu-akamai reviewed Sep 13, 2023

View reviewed changes

packages/manager/src/features/Firewalls/FirewallLanding/FirewallRow.tsx Outdated Show resolved Hide resolved

packages/manager/src/features/Firewalls/FirewallLanding/FirewallRow.tsx Outdated Show resolved Hide resolved

TylerWJ added 6 commits September 13, 2023 10:57

added Connie's pr suggestions

3f0e94b

updated styled row file

e45b88e

added line clamp to styled component

2200e2c

removed old test case

0a7f46a

updated row spacing

f5478c9

fixed spacing

1928ed6

coliu-akamai approved these changes Sep 13, 2023

View reviewed changes

jaalah-akamai approved these changes Sep 13, 2023

View reviewed changes

tyler-akamai merged commit d993fcc into linode:feature/firewall-nodebalancer Sep 13, 2023

tyler-akamai removed the Ready for Review label Sep 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7033] - Update Firewall Landing Device Column#9668

feat: [M3-7033] - Update Firewall Landing Device Column#9668
tyler-akamai merged 17 commits intolinode:feature/firewall-nodebalancerfrom
tyler-akamai:M3-7033-Update-Firewall-Landing-Device-Column

tyler-akamai commented Sep 13, 2023 •

edited

Loading

Uh oh!

coliu-akamai left a comment

Uh oh!

Uh oh!

Uh oh!

coliu-akamai commented Sep 13, 2023 •

edited

Loading

Uh oh!

coliu-akamai left a comment

Uh oh!

jaalah-akamai commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tyler-akamai commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Major Changes 🔄

Preview 📷

How to test 🧪

Uh oh!

coliu-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coliu-akamai commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coliu-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

jaalah-akamai commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tyler-akamai commented Sep 13, 2023 •

edited

Loading

coliu-akamai commented Sep 13, 2023 •

edited

Loading