test: [M3-7068] - Add integration tests for Linode migration dialog DC-specific pricing by cliu-akamai · Pull Request #9681 · linode/manager

cliu-akamai · 2023-09-14T20:31:46Z

Description 📝

Add new cypress tests for Linode migration dialog DC pricing

Major Changes 🔄

Add e2e tests to verify the DC pricing information in Linode migration dialog.

How to test 🧪

yarn cy:run -s "cypress/e2e/core/linodes/migrate-linode.spec.ts"

mjac0bs

Thanks for adding! Test passes. ✅

I left a few comments about minor clean up on some comments.

mjac0bs · 2023-09-15T21:30:00Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Suggested change

* - Confirms that pricing comparison is not shown in "Region" section migration occurs in the same DC.

* - Confirms that pricing comparison is not shown in "Region" section if migration occurs in a DC with the same price structure.

Here, it is the same DC, because that's the mock data we have to work with, but for clarity, it's probably best to note that the price notice shouldn't show up if the region prices are the same -- even if they're different regions.

mjac0bs · 2023-09-15T21:31:05Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Suggested change

* - Confirms that pricing comparison is shown in "Region" section when migration occurs in different DCs.

* - Confirms that pricing comparison is shown in "Region" section when migration occurs in DCs with different price structures.

Similar comment as below.

mjac0bs · 2023-09-15T21:31:31Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Suggested change

it('shows DC-specific pricing information when migrating linodes between different DCs', () => {

it('shows DC-specific pricing information when migrating linodes between differently priced DCs', () => {

mjac0bs · 2023-09-15T21:35:57Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Suggested change

// TODO Remove feature flag mocks once DC pricing is live.

// TODO: DC Pricing - M3-7073: Remove feature flag mocks once DC pricing is live.

mjac0bs · 2023-09-15T21:38:31Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Suggested change

// TODO Remove feature flag mocks once DC pricing is live.

// TODO: DC Pricing - M3-7073: Remove feature flag mocks once DC pricing is live.

For clarity and ease of clean up later, let's format DC pricing related TODOs with TODO: DC Pricing. In this case, we have a related ticket number, so it's useful to include that too.

mjac0bs · 2023-09-15T21:42:03Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Do we mean that this test just not exist once DC-pricing goes live? The other two test cases test that pricing information is shown and isn't shown depending on region prices.

Yes, I think so.

jdamore-linode

Nice work @cliu-akamai! I agree with the clean up suggestions that Mariah made, and additionally have a few suggestions of my own.

It also seems like there may've been a misunderstanding on the requirements for one of the tests, so I posted a pair of comments (1, 2) that I hope will clear that up without sacrificing any of the coverage you've already added 👍

jdamore-linode · 2023-09-18T17:24:09Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Could we define a helper in support/intercepts/linodes.ts named mockMigrateLinode() that does this?

jdamore-linode · 2023-09-18T17:26:52Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Suggested change

// Mock requests to get all Linode types, and to get individual types.

mockGetLinodeType(dcPricingMockLinodeTypes[0]).as('getLinodeTypeOld');

mockGetLinodeType(dcPricingMockLinodeTypes[1]).as('getLInodeTypeNew');

// Mock requests to get individual Linode types.

mockGetLinodeType(dcPricingMockLinodeTypes[0]);

mockGetLinodeType(dcPricingMockLinodeTypes[1]);

No need to assign an alias via .as("..."); here since we don't cy.wait() for it later 👍

jdamore-linode · 2023-09-18T17:27:56Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Suggested change

// Mock requests to get all Linode types, and to get individual types.

mockGetLinodeType(dcPricingMockLinodeTypes[0]).as('getLinodeTypeOld');

mockGetLinodeType(dcPricingMockLinodeTypes[1]).as('getLInodeTypeNew');

// Mock requests to get individual Linode types.

mockGetLinodeType(dcPricingMockLinodeTypes[0]);

mockGetLinodeType(dcPricingMockLinodeTypes[1]);

(Same as my other comment)

jdamore-linode · 2023-09-18T17:46:22Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Expanding on Mariah's suggestion, I think there might be a misunderstanding over the requirements for this one.

We want to test that the DC-specific pricing warnings do not appear if we're migrating from one DC to another DC which has the same pricing structure. Right now, the tests confirm that the user can't select the same region where the Linode is already hosted (which is good to have, too!)

We can extend this pretty easily to cover both cases, but we need to modify these two constants first so that 1) they're two different regions, and 2) they're not the same regions we mock in dcPricingMockLinodeTypes

Suggested change

const initialRegion = getRegionById('us-west');

const newRegion = getRegionById('us-west');

const initialRegion = getRegionById('us-southeast');

const newRegion = getRegionById('us-central');

jdamore-linode · 2023-09-18T17:49:36Z

packages/manager/cypress/e2e/core/linodes/migrate-linode.spec.ts

Following up from my other comment, we can extend these assertions to ensure that the test covers both flows: that the user cannot select the same DC where the Linode is already hosted, and that when the user selects another DC with the same price structure, no DC-specific pricing information is shown.

Suggested change

containsClick(selectRegionString).type(`${newRegion.label}{enter}`);

cy.findByText('No results').should('be.visible');

// No DC pricing information shows up

cy.findByText(dcPricingCurrentPriceLabel).should('not.exist');

cy.get('[data-testid="current-price-panel"]').should('not.exist');

cy.findByText(dcPricingNewPriceLabel).should('not.exist');

cy.get('[data-testid="new-price-panel"]').should('not.exist');

// Confirm that user cannot select the Linode's current DC when migrating.

cy.findByText('New Region')

.click()

.type(`${initialRegion.label}{enter}`);

cy.findByText('No results').should('be.visible');

// Confirm that DC pricing information does not show up

cy.findByText(dcPricingCurrentPriceLabel).should('not.exist');

cy.get('[data-testid="current-price-panel"]').should('not.exist');

cy.findByText(dcPricingNewPriceLabel).should('not.exist');

cy.get('[data-testid="new-price-panel"]').should('not.exist');

// Change region selection to another region with the same price structure.

cy.findByText('New Region')

.click()

.type(`${newRegion.label}{enter}`);

// Confirm that DC pricing information still does not show up.

cy.findByText(dcPricingCurrentPriceLabel).should('not.exist');

cy.get('[data-testid="current-price-panel"]').should('not.exist');

cy.findByText(dcPricingNewPriceLabel).should('not.exist');

cy.get('[data-testid="new-price-panel"]').should('not.exist');

// Confirm that migration queue button is enabled.

ui.button

.findByTitle('Enter Migration Queue')

.should('be.visible')

.should('be.enabled');

jdamore-linode

Thanks for the updates @cliu-akamai, everything looks great!

…pricing

cliu-akamai requested a review from jdamore-linode September 14, 2023 20:31

mjac0bs assigned cliu-akamai Sep 14, 2023

mjac0bs added the DC-Specific Pricing label Sep 14, 2023

mjac0bs changed the title ~~test: [M3-7068] - Add Cypress integration tests for Linode migration dialog DC …~~ test: [M3-7068] - Add integration tests for Linode migration dialog DC-specific pricing Sep 15, 2023

mjac0bs self-requested a review September 15, 2023 16:10

mjac0bs approved these changes Sep 15, 2023

View reviewed changes

jdamore-linode requested changes Sep 18, 2023

View reviewed changes

cliu-akamai requested a review from a team as a code owner September 19, 2023 15:43

cliu-akamai requested review from bnussman-akamai and dwiley-akamai and removed request for a team September 19, 2023 15:43

jdamore-linode approved these changes Sep 19, 2023

View reviewed changes

M3-7068 Add Cypress integration tests for Linode migration dialog DC …

42e190b

…pricing

cliu-akamai force-pushed the feature/M3-7068 branch from 6da86a1 to 42e190b Compare September 19, 2023 21:14

cliu-akamai merged commit 677a17d into linode:develop Sep 20, 2023

cliu-akamai deleted the feature/M3-7068 branch September 20, 2023 00:17

	* - Confirms that pricing comparison is not shown in "Region" section migration occurs in the same DC.
	* - Confirms that pricing comparison is not shown in "Region" section if migration occurs in a DC with the same price structure.

	it('shows DC-specific pricing information when migrating linodes between different DCs', () => {
	it('shows DC-specific pricing information when migrating linodes between differently priced DCs', () => {

	// TODO Remove feature flag mocks once DC pricing is live.
	// TODO: DC Pricing - M3-7073: Remove feature flag mocks once DC pricing is live.

-    // Mock requests to get all Linode types, and to get individual types.
-    mockGetLinodeType(dcPricingMockLinodeTypes[0]).as('getLinodeTypeOld');
-    mockGetLinodeType(dcPricingMockLinodeTypes[1]).as('getLInodeTypeNew');
+    // Mock requests to get individual Linode types.
+    mockGetLinodeType(dcPricingMockLinodeTypes[0]);
+    mockGetLinodeType(dcPricingMockLinodeTypes[1]);

-    const initialRegion = getRegionById('us-west');
-    const newRegion = getRegionById('us-west');
+    const initialRegion = getRegionById('us-southeast');
+    const newRegion = getRegionById('us-central');

-    containsClick(selectRegionString).type(`${newRegion.label}{enter}`);
-    cy.findByText('No results').should('be.visible');
-    // No DC pricing information shows up
-    cy.findByText(dcPricingCurrentPriceLabel).should('not.exist');
-    cy.get('[data-testid="current-price-panel"]').should('not.exist');
-    cy.findByText(dcPricingNewPriceLabel).should('not.exist');
-    cy.get('[data-testid="new-price-panel"]').should('not.exist');
+   // Confirm that user cannot select the Linode's current DC when migrating.
+   cy.findByText('New Region')
+     .click()
+     .type(`${initialRegion.label}{enter}`);
+   cy.findByText('No results').should('be.visible');
+   // Confirm that DC pricing information does not show up
+   cy.findByText(dcPricingCurrentPriceLabel).should('not.exist');
+   cy.get('[data-testid="current-price-panel"]').should('not.exist');
+   cy.findByText(dcPricingNewPriceLabel).should('not.exist');
+   cy.get('[data-testid="new-price-panel"]').should('not.exist');
+   // Change region selection to another region with the same price structure.
+   cy.findByText('New Region')
+     .click()
+     .type(`${newRegion.label}{enter}`);
+   // Confirm that DC pricing information still does not show up.
+   cy.findByText(dcPricingCurrentPriceLabel).should('not.exist');
+   cy.get('[data-testid="current-price-panel"]').should('not.exist');
+   cy.findByText(dcPricingNewPriceLabel).should('not.exist');
+   cy.get('[data-testid="new-price-panel"]').should('not.exist');
+   // Confirm that migration queue button is enabled.
+   ui.button
+     .findByTitle('Enter Migration Queue')
+     .should('be.visible')
+     .should('be.enabled');

Conversation

cliu-akamai commented Sep 14, 2023 • edited by mjac0bs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Major Changes 🔄

How to test 🧪

Uh oh!

mjac0bs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdamore-linode left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdamore-linode Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdamore-linode left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cliu-akamai commented Sep 14, 2023 •

edited by mjac0bs

Loading

jdamore-linode left a comment •

edited

Loading

jdamore-linode Sep 18, 2023 •

edited

Loading