fix: [M3-7078] codeQL warning with analytics.ts

[abailly-akamai]

Description 📝

This pr fixes this codeQL warning and type the _satellite object a bit better

Major Changes 🔄

• Escape expression in eventPayload replaced values
• Ensure all occurrences of | are replaced (as opposed to one before)

How to test 🧪

Setup:

1. Pull code locally
2. Follow the local analytics debugging setup

Steps:

1. Navigate to /linodes
2. Open any action menu and observe the analytic event in the console
3. Modify the sendLinodeActionEvent method to include one or several | (pipe) characters
4. Confirm they all get removed from the event payload

[dwiley-akamai]

Do extra spaces in the category name impact the integrity of the analytics? Two examples below:

Example 1

Change in code:

Logged to console:

Example 2

Change in code:

Logged to console:

Would those end up getting classified as different categories?

[abailly-akamai]

@dwiley-akamai I don't think so and couldn't find a reference to extra in the docs and elsewhere.

It should be noted that the pipe delimiter in custom events does is already a bit of an edge case we document (we are the ones defining those).

[mjac0bs]

Thanks for the improvements!

Yeah. | is an edge case of our own because of the way that our Analytics team is reading and delimiting these custom event attributes in Adobe, and so while we should avoid introducing pipes into our custom events in the first place, it's great to fix the warning and correctly prevent developer error.

[mjac0bs]

Thanks! 😅

[mjac0bs]

Nice!

[bnussman-akamai]

I confirmed that the .replace works! ✅

Nice improvement to the types!