fix: [M3-7008] - Invoice and Payment id wrapping in generated PDFs#9702
Conversation
bnussman-akamai
requested review from
carrillo-erik and
mjac0bs
and removed request for
a team
| }); | ||
| const titlePosition = addTitle( | ||
| doc, | ||
| Math.max(leftHeaderYPosition, rightHeaderYPosition) + 12, |
There was a problem hiding this comment.
I changed 4 to 12 to match the payment PDFs. It helps make the PDF a bit more readable (see before and after photos above).
| fillColor: '#444444', | ||
| }, | ||
| startY: 165, | ||
| startY, |
There was a problem hiding this comment.
startY is now dynamic instead of hard-coded. This allows the table to be dynamically positioned so that the header text will not overlap with the table.
There was a problem hiding this comment.
Good choice, the dynamic value definitely improves the table's aesthetic.
|
Looks good to me 👀 👍. I was able to download and inspect both the Invoice and the Receipt PDFs. The long numbers do not overlap or cause any visual regressions and are positioned correctly within the PDF.
I did observe a discrepancy if I clicked the link
|
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Confirmed no wrapping or obscured confirmation numbers on the invoices and payments that I clicked through. Thanks for fixing! 🚢
5 participants
Description 📝
Important
I recommend checking the internal ticket to see context of this 🪲
Fixes unnecessary wrap in invoice and payment PDFs that caused some
idnumbers to be partially cut off and improves general positioningMajor Changes 🔄
addTitlefunctionPreview 📷
How to test 🧪
http://localhost:3000/account/billingInvoice with Large IDand verify the textInvoice: #123456789123456is positioned correctly and is not overlapping anythingPayment #123456789123456and verify the textReceipt for Payment #123456789123456is positioned correctly and is not overlapping anything