feat: [M3-7157] - Only show IPv4s specific to a linode-subnet relationship on VPC details page#9710
Merged
coliu-akamai merged 5 commits intolinode:developfrom Sep 26, 2023
Conversation
coliu-akamai
requested review from
abailly-akamai and
bnussman-akamai
and removed request for
a team
coliu-akamai
requested review from
dwiley-akamai,
hana-akamai and
jaalah-akamai
bnussman-akamai
approved these changes
Sep 22, 2023
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Logic looks good. From the mocking I tried, I saw the correct VPC IP!
coliu-akamai
added
Add'tl Approval Needed
abailly-akamai
approved these changes
Sep 25, 2023
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
correct IP showing as expected in the UI ✅
Approving pending additional coverage. thx!
| } | ||
| } | ||
|
|
||
| return undefined; |
Contributor
There was a problem hiding this comment.
Can we move this to a .utils.ts and get it tested with a factory?
hana-akamai
approved these changes
Sep 25, 2023
Contributor
hana-akamai
left a comment
hana-akamai
left a comment
There was a problem hiding this comment.
Confirmed the correct IP and that the existing unit test still passes 🔨
coliu-akamai
added
Approved
dwiley-akamai
approved these changes
Sep 25, 2023
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
The VPC IPv4 displayed matches the IPv4 address expected ✅
Unit tests pass ✅
Contributor
Author
|
thanks everyone! merging this PR as the integration test failure is unrelated to VPC changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Ensure that a linode row inside the subnets table only shows the IP specific to that subnet
Major Changes 🔄
Add subnetId to SubnetLinodeRow props, and find the interface associated with that specific subnet
Preview 📷
MSW example:
How to test 🧪
How to verify changes?
packages/manager/src/factories/linodeConfigInterfaceFactory.tsline 28 and try to put in specific subnet_ids. If the mock subnet_id matches, the IPs will show up (see MSW screenshot example)packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx, and check the interfaces in the configs. The interface with the corresponding subnetId should have the same IPv4 as the one appearing in the row)How to run Unit or E2E tests?
yarn test SubnetLinodeRow(existing test should still pass)yarn test 'packages/manager/src/features/VPCs/utils.test.ts'