Skip to content

fix: [M3-7192] - Account Users Add A User Button Alignment#9721

Merged
bnussman-akamai merged 2 commits intolinode:developfrom
bnussman-akamai:fix/account-users-ui-styles
Sep 28, 2023
Merged

fix: [M3-7192] - Account Users Add A User Button Alignment#9721
bnussman-akamai merged 2 commits intolinode:developfrom
bnussman-akamai:fix/account-users-ui-styles

Conversation

@bnussman-akamai
Copy link
Member

Description 📝

  • Fixes styles on the http://localhost:3000/account/users page 🎨
  • Removes tons of unused styled 🗑️

Preview 📷

Before After
Screenshot 2023-09-26 at 3 12 18 PM Screenshot 2023-09-26 at 3 12 25 PM

How to test 🧪

  • Go to http://localhost:3000/account/users and check the UI in general
  • Check the styles and positioning of the Add A User button

@bnussman-akamai bnussman-akamai added the UX/UI Changes for UI/UX to review label Sep 26, 2023
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner September 26, 2023 19:17
@bnussman-akamai bnussman-akamai self-assigned this Sep 26, 2023
@bnussman-akamai bnussman-akamai requested review from cliu-akamai and cpathipa and removed request for a team September 26, 2023 19:17
@bnussman-akamai bnussman-akamai changed the title fix: Account Users Add A User Button Alignment fix: [M3-7192] - Account Users Add A User Button Alignment Sep 26, 2023
@bnussman-akamai
Copy link
Member Author

I decided not to add any additional padding on mobile viewports because

  • it would require one-off styling
  • other headers like our main "LandingHeader" do not apply any padding on mobile viewports to the primary button (see below)
Before After
Screenshot 2023-09-26 at 3 32 59 PM Screenshot 2023-09-26 at 3 32 52 PM

@bnussman-akamai bnussman-akamai added the Bug Fixes for regressions or bugs label Sep 26, 2023
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified the alignment of Add A User button.
Not related to this PR, I noticed that the 'Maintenance' tab's 'Download CSV' button link also has some padding and is not aligned like the 'Add A User' button.
image

@bnussman-akamai
Copy link
Member Author

Fair point. The Download CSV button is technically aligned, it is just a secondary button with the ripple disabled, making it seem misaligned

Screenshot 2023-09-27 at 10 14 30 AM

@carrillo-erik
Copy link
Contributor

Sweet, nice refactor removing the old styles it definitely helps to reduce the lines of code per file. I was able to inspect the button alignment by running your PR on my local machine.

Screenshot 2023-09-28 at 7 55 58 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fixes for regressions or bugs UX/UI Changes for UI/UX to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants