test: Resolve Cypress test flake for Linode config edit test#9781
test: Resolve Cypress test flake for Linode config edit test#9781jdamore-linode merged 3 commits intolinode:developfrom
Conversation
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks for the fix! Ran the spec locally 4 times and tests passed 100% of the time. 🚢
|
Intentionally missing a changeset here? As far as the failing e2es: |
Haha, no more intentionally missing changesets from my end -- just slipped through the cracks! The runner issue is unfortunate and has been impacting pretty much all of our runs today (I'm not sure what changed to cause this, but there was some discussion in the API frontend channel about it for more context). In the meantime, I just swapped in a new test account as a temporary workaround so runner #1 should stop failing prematurely now 🤞 I'm going to kick off a new run since we missed out on a quarter of the tests, but yeah, the longview one is another that can be disregarded because it's been generally troublesome lately :/ |

Description 📝
This addresses the flake and failures we've been having with the
Edits an existing configtest inlinodes/linode-config.spec.ts.The tests were failing because the API would respond with a 400 upon editing a config while a Linode was still provisioning; specifically, the failure occurs when the disks listed in the Linode's config aren't ready when editing the config.
This fixes the issue by waiting for the Linode's disks to be
readybefore attempting to edit the configs.Changes 🔄
List any change relevant to the reviewer.
pollLinodeDiskStatuses()polling utilityHow to test 🧪
Without these changes, the
Edit Configtest fails relatively frequently (maybe 1 in 4 runs? Only estimating), but with these changes in place I was able to run the edit test 20 times in a row and they all passed.yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"As an Author I have considered 🤔
Check all that apply